Re: [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger

Krzysztof Kozlowski
2022-06-24T10:27:51Z

On 23/06/2022 13:56, ChiaEn Wu wrote:
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add Mediatek MT6370 Charger binding documentation.
>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
>
> v3
> - Add items and remove maxItems of io-channels
> - Add io-channel-names and describe each item
> - Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
> - Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"
> ---
> .../power/supply/mediatek,mt6370-charger.yaml | 87 ++++++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> new file mode 100644
> index 0000000..f138db6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6370 Battery Charger
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-charger
> +
> + interrupts:
> + description: |
> + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
> + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
> + are required.
> + items:
> + - description: BC1.2 done irq
> + - description: usb plug in irq
> + - description: mivr irq
> +
> + interrupt-names:
> + items:
> + - const: attach_i
> + - const: uvp_d_evt
> + - const: mivr
> +
> + io-channels:
> + description: |
> + Use ADC channel to read VBUS, IBUS, IBAT, etc., info.
> + minItems: 1
> + items:
> + - description: |
> + VBUS voltage with lower accuracy (+-75mV) but higher measure
> + range (1~22V)
> + - description: |
> + VBUS voltage with higher accuracy (+-30mV) but lower measure
> + range (1~9.76V)
> + - description: the main system input voltage
> + - description: battery voltage
> + - description: battery temperature-sense input voltage
> + - description: IBUS current (required)
> + - description: battery current
> + - description: |
> + regulated output voltage to supply for the PWM low-side gate driver
> + and the bootstrap capacitor
> + - description: IC junction temperature
> +
> + io-channel-names:

It does not match io-channels, you need minItems here as well.

> + items:
> + - const: vbusdiv5
> + - const: vbusdiv2
> + - const: vsys
> + - const: vbat
> + - const: ts_bat
> + - const: ibus
> + - const: ibat
> + - const: chg_vddp
> + - const: temp_jc
> +

Best regards,
Krzysztof