Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight

ChiaEn Wu
2022-06-24T09:34:51Z

Hi Joe,

Joe Simmons-Talbott <joetalbott@gmail.com> 於 2022年6月23日 週四 晚上9:17寫道：
>
> On Thu, Jun 23, 2022 at 07:56:22PM +0800, ChiaEn Wu wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add mt6370 backlight binding documentation.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> >
> > v3
> > - Rename "mediatek,bled-pwm-hys-input-threshold-steps" to
> > "mediatek,bled-pwm-hys-input-th-steps"
> > - Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt",
> > "bled-ocp-microamp" enum values
> > ---
> > .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++
> > 1 file changed, 92 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> > new file mode 100644
> > index 0000000..26563ae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> > @@ -0,0 +1,92 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT6370 Backlight
> > +
> > +maintainers:
> > + - ChiaEn Wu <chiaen_wu@richtek.com>
> > +
> > +description: |
> > + This module is part of the MT6370 MFD device.
> > + The MT6370 Backlight WLED driver supports up to a 29V output voltage for
> > + 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
> > + capability with 2048 current steps (11 bits) in exponential or linear
> > + mapping curves.
> > +
> > +allOf:
> > + - $ref: common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6370-backlight
> > +
> > + default-brightness:
> > + minimum: 0
> > + maximum: 2048
> > +
> > + max-brightness:
> > + minimum: 0
> > + maximum: 2048
> > +
> > + enable-gpios:
> > + description: External backlight 'enable' pin
> > + maxItems: 1
> > +
> > + mediatek,bled-pwm-enable:
> > + description: |
> > + Enable external PWM input for backlight dimming
> > + type: boolean
> > +
> > + mediatek,bled-pwm-hys-enable:
> > + description: |
> > + Enable the backlight input-hysteresis for PWM mode
> > + type: boolean
> > +
> > + mediatek,bled-pwm-hys-input-th-steps:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + enum: [1, 4, 16, 64]
> > + description: |
> > + The selection of the upper and lower bounds threshold of backlight
> > + PWM resolution. If we choose selection 64, the variation of PWM
> > + resolution needs over than 64 steps.
>
> more than?
>
> Thanks,
> Joe
>

Thanks for your helpful comments!
I will revise this in the next patch. Thanks!

> > +
> > + mediatek,bled-ovp-shutdown:
> > + description: |
> > + Enable the backlight shutdown when OVP level triggered
> > + type: boolean
> > +
> > + mediatek,bled-ovp-microvolt:
> > + enum: [17000000, 21000000, 25000000, 29000000]
> > + description: |
> > + Backlight OVP level selection.
> > +
> > + mediatek,bled-ocp-shutdown:
> > + description: |
> > + Enable the backlight shutdown when OCP level triggerred.
> > + type: boolean
> > +
> > + mediatek,bled-ocp-microamp:
> > + enum: [900000, 1200000, 1500000, 1800000]
> > + description: |
> > + Backlight OC level selection.
> > +
> > + mediatek,bled-channel-use:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + description: |
> > + Backlight LED channel to be used.
> > + Each bit mapping to:
> > + - 0: CH4
> > + - 1: CH3
> > + - 2: CH2
> > + - 3: CH1
> > + minimum: 1
> > + maximum: 15
> > +
> > +required:
> > + - compatible
> > + - mediatek,bled-channel-use
> > +
> > +additionalProperties: false
> > --
> > 2.7.4
> >

Best regards,
ChiaEn Wu