Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

Andy Shevchenko
2022-06-23T19:15:07Z

On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add mt6370 DisplayBias and VibLDO support.

...

> +#include <linux/bits.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/interrupt.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>

> +#include <linux/of.h>

Any users of this? (See below)

> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

...

> +#define MT6370_LDO_MINUV 1600000
> +#define MT6370_LDO_STPUV 200000
> +#define MT6370_LDO_N_VOLT 13
> +#define MT6370_DBVBOOST_MINUV 4000000
> +#define MT6370_DBVBOOST_STPUV 50000
> +#define MT6370_DBVBOOST_N_VOLT 45
> +#define MT6370_DBVOUT_MINUV 4000000
> +#define MT6370_DBVOUT_STPUV 50000
> +#define MT6370_DBVOUT_N_VOLT 41

If UV is a unit suffix, make it _UV.

...

> + .of_match = of_match_ptr("dsvbst"),

Would it even be called / used if CONFIG_OF=n?

...

> + .regulators_node = of_match_ptr("regulators"),

Ditto.

...

> + for (i = 0; i < ARRAY_SIZE(mt6370_irqs); i++) {
> + irq = platform_get_irq_byname(pdev, mt6370_irqs[i].name);
> +
> + rdev = priv->rdev[mt6370_irqs[i].rid];
> +
> + ret = devm_request_threaded_irq(priv->dev, irq, NULL,
> + mt6370_irqs[i].handler, 0,
> + mt6370_irqs[i].name, rdev);
> + if (ret) {

> + dev_err(priv->dev,
> + "Failed to register (%d) interrupt\n", i);
> + return ret;

return dev_err_probe(...); ?

> + }
> + }

...

> + for (i = 0; i < MT6370_MAX_IDX; i++) {
> + rdev = devm_regulator_register(priv->dev,
> + mt6370_regulator_descs + i,
> + &cfg);
> + if (IS_ERR(rdev)) {

> + dev_err(priv->dev,
> + "Failed to register (%d) regulator\n", i);
> + return PTR_ERR(rdev);

return dev_err_probe(...); ?

> + }
> +
> + priv->rdev[i] = rdev;
> + }

...

> + if (!priv->regmap) {
> + dev_err(&pdev->dev, "Failed to init regmap\n");
> + return -ENODEV;
> + }

return dev_err_probe(...);

--
With Best Regards,
Andy Shevchenko