Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support

szuni chen
2022-06-24T07:20:41Z

Hi Linus,

Thank you for the comment.

Linus Walleij <linus.walleij@linaro.org> 於 2022年6月24日 週五 下午2:25寫道：
>
> On Fri, Jun 24, 2022 at 8:23 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> > Thanks for your patch!
> >
> > On Thu, Jun 23, 2022 at 1:58 PM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
> >
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Add Mediatek MT6370 current sink type LED Indicator driver.
> > >
> > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > (...)
> > > drivers/leds/Kconfig | 11 +
> > > drivers/leds/Makefile | 1 +
> > > drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++
> >
> > There is a drivers/leds/flash subdirectory these days, put the driver
> > in that directory instead.
>
> Sorry I'm commenting on the wrong patch.
>
> I meant this one. Move that into drivers/leds/flash
> drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++

In next version, I'll use "leds: flash: ......" instead of "leds:
flashlight: ......" in subject.
May I confirm that the driver has already in the drivers/leds/flash,
so I don’t have to move it in next version?

Sincerely,
Alice Chen