From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661BEC43334 for ; Sat, 25 Jun 2022 13:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbiFYNRK (ORCPT ); Sat, 25 Jun 2022 09:17:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231982AbiFYNRI (ORCPT ); Sat, 25 Jun 2022 09:17:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2020011821; Sat, 25 Jun 2022 06:17:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4AA5612CB; Sat, 25 Jun 2022 13:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 641EDC3411C; Sat, 25 Jun 2022 13:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656163024; bh=EQ5NzjxPicxRp5lCLKniHD4eu7yQO6P2W6htjFIhPvo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oNKh52OCnc31NiXe1GV1IVpnKRb03djN/vdb0EGtjIegIo1BGnsdA9aMFihL5Ak1d 6KBakA5oxES5lSMArs9M+KgHNR84Ty3R2yWpDAYZ+A7rjy8nVsLmu4Qmg8RXng0Km/ 0VbXRxWOEdiwaWVPRnSfJNhabxbqUEy6WeHWoqrxoN8goScd2aORNwATDP8QVDKXmU R8xDqhPLCTZD597FDJZ8ay+kv3s6s4SA+zPyqNk9RKPGWckLs61i6oOyXax9vZkQe+ dTqaJFa5Nmt2EySO13vQzkmn64S01t9xHhXorrW8fi+L5b0G5wm8dglZRncGWz8IZZ uBOihqtn2BaxQ== Date: Sat, 25 Jun 2022 14:26:32 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Jiang Jian , Lars-Peter Clausen , Michael Hennerich , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH] iio: dac: ad5380: aligned '*' each line and drop unneeded blank line Message-ID: <20220625142632.1d0201a1@jic23-huawei> In-Reply-To: References: <20220621092319.69598-1-jiangjian@cdjrlc.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 21 Jun 2022 16:08:14 +0200 Andy Shevchenko wrote: > On Tue, Jun 21, 2022 at 11:26 AM Jiang Jian wrote: > > > > Consider '*' alignment in the comments of struct ad5380_chip_info declaration. > > Next time don't forget to bump the version of the patch (use -vX, X = > 0,1, ..., with the `git format-patch`) and add a changelog (after > cutter '---' line). > > > ... > > > * @channel_template: channel specification template > > > * @num_channels: number of channels > > > * @int_vref: internal vref in uV > > > -*/ > > > + */ > > > > > While at it, drop the unneeded blank line here. > > > struct ad5380_chip_info { > > ... > > } > > This should be replaced by something simpler, like: > While at it, drop the unneeded blank lines. > > Reviewed-by: Andy Shevchenko > > I do not think you need to resend this simplest patch and Jonathan > will help you this time, but consider the above for future > contributions, thanks! Tweaked and applied to the togreg branch of iio.git which I'll push out initially as testing to let the 0-day bot poke it. Thanks, Jonathan > > > Signed-off-by: Jiang Jian > > --- > > drivers/iio/dac/ad5380.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c > > index a44c83242fb1..81775152aac6 100644 > > --- a/drivers/iio/dac/ad5380.c > > +++ b/drivers/iio/dac/ad5380.c > > @@ -36,8 +36,7 @@ > > * @channel_template: channel specification template > > * @num_channels: number of channels > > * @int_vref: internal vref in uV > > -*/ > > - > > + */ > > struct ad5380_chip_info { > > struct iio_chan_spec channel_template; > > unsigned int num_channels; > > @@ -53,7 +52,6 @@ struct ad5380_chip_info { > > * @pwr_down: whether the chip is currently in power down mode > > * @lock: lock to protect the data buffer during regmap ops > > */ > > - > > struct ad5380_state { > > struct regmap *regmap; > > const struct ad5380_chip_info *chip_info; > > -- > > 2.17.1 > > > > > -- > With Best Regards, > Andy Shevchenko