Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: adc: ti-ads124s08: Drop unused parameter to ads124s_read()
Date: Mon, 18 Jul 2022 18:44:06 +0100	[thread overview]
Message-ID: <20220718184406.727900fa@jic23-huawei> (raw)
In-Reply-To: <20220626153828.589664-1-jic23@kernel.org>

On Sun, 26 Jun 2022 16:38:28 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> The channel number is never used in this call, so don't pass it in.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This one is so trivial I've picked it up without pestering anyone for review.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ti-ads124s08.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> index 64833156c199..4ca62121f0d1 100644
> --- a/drivers/iio/adc/ti-ads124s08.c
> +++ b/drivers/iio/adc/ti-ads124s08.c
> @@ -193,7 +193,7 @@ static int ads124s_reset(struct iio_dev *indio_dev)
>  	return 0;
>  };
>  
> -static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
> +static int ads124s_read(struct iio_dev *indio_dev)
>  {
>  	struct ads124s_private *priv = iio_priv(indio_dev);
>  	int ret;
> @@ -242,7 +242,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
>  			goto out;
>  		}
>  
> -		ret = ads124s_read(indio_dev, chan->channel);
> +		ret = ads124s_read(indio_dev);
>  		if (ret < 0) {
>  			dev_err(&priv->spi->dev, "Read ADC failed\n");
>  			goto out;
> @@ -290,7 +290,7 @@ static irqreturn_t ads124s_trigger_handler(int irq, void *p)
>  		if (ret)
>  			dev_err(&priv->spi->dev, "Start ADC conversions failed\n");
>  
> -		priv->buffer[j] = ads124s_read(indio_dev, scan_index);
> +		priv->buffer[j] = ads124s_read(indio_dev);
>  		ret = ads124s_write_cmd(indio_dev, ADS124S08_STOP_CONV);
>  		if (ret)
>  			dev_err(&priv->spi->dev, "Stop ADC conversions failed\n");


      reply	other threads:[~2022-07-18 17:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 15:38 [PATCH] iio: adc: ti-ads124s08: Drop unused parameter to ads124s_read() Jonathan Cameron
2022-07-18 17:44 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718184406.727900fa@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox