From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B2EC433EF for ; Tue, 19 Jul 2022 08:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236960AbiGSIhP (ORCPT ); Tue, 19 Jul 2022 04:37:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235846AbiGSIhP (ORCPT ); Tue, 19 Jul 2022 04:37:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DA5824F17 for ; Tue, 19 Jul 2022 01:37:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 046156177D for ; Tue, 19 Jul 2022 08:37:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B4F7C341C6; Tue, 19 Jul 2022 08:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658219833; bh=OfqS65e3vsZsI3lyapWkjKnDF8YB/quv9ORXjIOofXs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RbtiR67vsCYZHX3VFEeL5k1ykdv3OEBB/ma/u66OW7C8ctc0dSpGrmPL1tFvnVSJQ lawUCLNLMRmFCoNF9Omrz4stZFWUCKVZLduhpefFXghTe/JLZyrcAl/psl0AM+XAc1 Tc753D0s3GqCcsBXuvUWk6Eg/zzcgC1NTvwg//XZSHhMpB0TGbRE4TM/NnLP4KE7xy /H/LQeqckZbHmTrWrv9tXv7ntcRJEshxIYlQ3sf8/uiLt+AZQnSKwmlhJd793FSUsL ANFUPFQbsbbEIz8RUD1d84ZHuNy305sg2X/LpsQDWl+HPuFVINqRPSyX2NA+LPRd8L UBUQ45xjfdUgA== Date: Tue, 19 Jul 2022 09:47:09 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Lars-Peter Clausen , Andy Shevchenko , linux-iio , Yves-Alexis Perez Subject: Re: [PATCH v2 3/3] iio: humidity: dht11: Use dev_err_probe consistently Message-ID: <20220719094709.78a52856@jic23-huawei> In-Reply-To: References: <20220718194258.181738-1-ukleinek@debian.org> <20220718194258.181738-3-ukleinek@debian.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 18 Jul 2022 22:32:17 +0200 Andy Shevchenko wrote: > On Mon, Jul 18, 2022 at 10:29 PM Andy Shevchenko > wrote: > > On Mon, Jul 18, 2022 at 9:51 PM Uwe Kleine-K=C3=B6nig wrote: =20 >=20 > ... >=20 > > And to be honest I don't like this desc_to_gpio() usage. It's not for > > board files, it will bring confusing information to the user. What is > > important is the name of GPIO, i.o.w. "connection id". =20 >=20 > Yes, I have noticed that this is in the original code, just if you > want to make it better at the same time. Not sure if Jonathan wants > all these in the single patch again, however it will touch almost the > same line in all (three ?). >=20 So ideal would be separate patches for the different change types, but meh, that's a pain as you say so given it's just a few lines I'm fine with whatever combining you want to do.