From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 110ECC00140 for ; Sun, 31 Jul 2022 12:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232268AbiGaMXt (ORCPT ); Sun, 31 Jul 2022 08:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiGaMXt (ORCPT ); Sun, 31 Jul 2022 08:23:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4519095A0; Sun, 31 Jul 2022 05:23:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EC771B80D1D; Sun, 31 Jul 2022 12:23:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3318CC433D6; Sun, 31 Jul 2022 12:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659270225; bh=/xtBcibcR1O/mDtgYXRCM38rkzxKP0vEboH12OrYl/Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lcB2cZZx3vzEDtHd+pVcUVXfSGhO2Nb5JUOMkW9Xe2A9IoviKOIvFXelW1ob2o2rI KKylV+qAbwZoRUxFaA5cza6t5mMBWHnhfkTLww/LEqg3OkQmtG1aTrxTTBsGwFDfPv aBM4OnW2D8ZROPGa9xEi0V8N54P6Q39aZSFtoAMfqbu/nEMCaYbxtde86SMYN5kBBf DSkkb5mQG/K2LlhqRd7PR2ygbEsBNTiwyAXexfdl7ghO4qS1NuAEivgLyfQCcm5AKl DS1R20B3LauaEnTPVyC0AFbCETBPjS1a8F3CcFZ6/NPuNgWAgZ1NSPwhTjkQPHJ/Js nBZT1kZ6zAA+A== Date: Sun, 31 Jul 2022 13:33:57 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Tomislav Denis , Lars-Peter Clausen Subject: Re: [PATCH v1 1/1] iio: pressure: dlhl60d: Don't take garbage into consideration when reading data Message-ID: <20220731133357.5705df25@jic23-huawei> In-Reply-To: <20220726142048.4494-1-andriy.shevchenko@linux.intel.com> References: <20220726142048.4494-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 26 Jul 2022 17:20:48 +0300 Andy Shevchenko wrote: > Both pressure and temperature are 24-bit long. Use proper accessors > instead of overlapping readings. > > Signed-off-by: Andy Shevchenko Looks correct to me, but it made me scratch my head just enough that I'd like Tomislav to take a look if possible. So give me a poke if this hasn't progressed in a few weeks time. Thanks, Jonathan > --- > drivers/iio/pressure/dlhl60d.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/pressure/dlhl60d.c b/drivers/iio/pressure/dlhl60d.c > index 5f6bb3603a8b..f0b0d198c6d4 100644 > --- a/drivers/iio/pressure/dlhl60d.c > +++ b/drivers/iio/pressure/dlhl60d.c > @@ -129,9 +129,8 @@ static int dlh_read_direct(struct dlh_state *st, > if (ret) > return ret; > > - *pressure = get_unaligned_be32(&st->rx_buf[1]) >> 8; > - *temperature = get_unaligned_be32(&st->rx_buf[3]) & > - GENMASK(DLH_NUM_TEMP_BITS - 1, 0); > + *pressure = get_unaligned_be24(&st->rx_buf[1]); > + *temperature = get_unaligned_be24(&st->rx_buf[4]); > > return 0; > }