Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Matt Ranostay <matt.ranostay@konsulko.com>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: add NULL pointer checks to iio device additional/removal
Date: Sat, 6 Aug 2022 15:46:56 +0100	[thread overview]
Message-ID: <20220806154656.4aa6ad9f@jic23-huawei> (raw)
In-Reply-To: <CAHp75VegV4YiY5WZ8SXmK9DCS1msKpmAykgYTskkHi+Zfx-U_g@mail.gmail.com>

On Wed, 3 Aug 2022 20:00:24 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Aug 3, 2022 at 7:57 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Aug 3, 2022 at 2:04 PM Matt Ranostay <matt.ranostay@konsulko.com> wrote:  
> > >
> > > Check if __iio_device_register and iio_device_unregister indio_dev
> > > parameter isn't a NULL pointer.  
> 
> A couple more things:
> - make sure you include all maintainers and reviewers (you may use my
> "smart" script [1] for that)
> - explain why you are doing this change
> 

Agreed. I'm not sure of the reasoning for doing this.
I'd also expect to see it as part of a series where we might pass NULL to these
functions.

Thanks,

Jonathan


> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
> 


      reply	other threads:[~2022-08-06 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 11:57 [PATCH] iio: add NULL pointer checks to iio device additional/removal Matt Ranostay
2022-08-03 17:57 ` Andy Shevchenko
2022-08-03 18:00   ` Andy Shevchenko
2022-08-06 14:46     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220806154656.4aa6ad9f@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox