[PATCH 0/2] IIO: Clean up a couple of warnings that snuck in.

[PATCH 0/2] IIO: Clean up a couple of warnings that snuck in.

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I'm not sure how these slipped through my local tests and 0-day.
These are definitely shown with W=1, perhaps not without that
but IIO is generally W=1 clean.

Jonathan Cameron (2):
  iio: test: Mark file local structure arrays static.
  iio: light: cm32181: Mark the dev_pm_ops static.

 drivers/iio/light/cm32181.c         | 2 +-
 drivers/iio/test/iio-test-rescale.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.37.1

[PATCH 1/2] iio: test: Mark file local structure arrays static.

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Warning cleanup:
  drivers/iio/test/iio-test-rescale.c:32:30: warning: symbol 'scale_cases' was not declared. Should it be static?
  drivers/iio/test/iio-test-rescale.c:480:30: warning: symbol 'offset_cases' was not declared. Should it be static?

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Liam Beguin <liambeguin@gmail.com>
---
 drivers/iio/test/iio-test-rescale.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/test/iio-test-rescale.c b/drivers/iio/test/iio-test-rescale.c
index cc782ccff880..31ee55a6faed 100644
--- a/drivers/iio/test/iio-test-rescale.c
+++ b/drivers/iio/test/iio-test-rescale.c
@@ -29,7 +29,7 @@ struct rescale_tc_data {
 	const char *expected_off;
 };
 
-const struct rescale_tc_data scale_cases[] = {
+static const struct rescale_tc_data scale_cases[] = {
 	/*
 	 * Typical use cases
 	 */
@@ -477,7 +477,7 @@ const struct rescale_tc_data scale_cases[] = {
 	},
 };
 
-const struct rescale_tc_data offset_cases[] = {
+static const struct rescale_tc_data offset_cases[] = {
 	/*
 	 * Typical use cases
 	 */
-- 
2.37.1

Re: [PATCH 1/2] iio: test: Mark file local structure arrays static.

[Liam Beguin]

On Sun, Aug 07, 2022 at 03:54:56PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Warning cleanup:
>   drivers/iio/test/iio-test-rescale.c:32:30: warning: symbol 'scale_cases' was not declared. Should it be static?
>   drivers/iio/test/iio-test-rescale.c:480:30: warning: symbol 'offset_cases' was not declared. Should it be static?
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Liam Beguin <liambeguin@gmail.com>

Reviewed-by: Liam Beguin <liambeguin@gmail.com>

> ---
>  drivers/iio/test/iio-test-rescale.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/test/iio-test-rescale.c b/drivers/iio/test/iio-test-rescale.c
> index cc782ccff880..31ee55a6faed 100644
> --- a/drivers/iio/test/iio-test-rescale.c
> +++ b/drivers/iio/test/iio-test-rescale.c
> @@ -29,7 +29,7 @@ struct rescale_tc_data {
>  	const char *expected_off;
>  };
>  
> -const struct rescale_tc_data scale_cases[] = {
> +static const struct rescale_tc_data scale_cases[] = {
>  	/*
>  	 * Typical use cases
>  	 */
> @@ -477,7 +477,7 @@ const struct rescale_tc_data scale_cases[] = {
>  	},
>  };
>  
> -const struct rescale_tc_data offset_cases[] = {
> +static const struct rescale_tc_data offset_cases[] = {
>  	/*
>  	 * Typical use cases
>  	 */
> -- 
> 2.37.1
> 

[PATCH 2/2] iio: light: cm32181: Mark the dev_pm_ops static.

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Only accessed from the local file.
Warning:
  drivers/iio/light/cm32181.c:508:1: warning: symbol 'cm32181_pm_ops' was not declared. Should it be static?

Fixes: 68c1b3dd5c48 ("iio: light: cm32181: Add PM support")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/iio/light/cm32181.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index edbe6a3138d0..001055d09750 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
 					 cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
 }
 
-DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
 
 static const struct of_device_id cm32181_of_match[] = {
 	{ .compatible = "capella,cm3218" },
-- 
2.37.1

Re: [PATCH 0/2] IIO: Clean up a couple of warnings that snuck in.

[Andy Shevchenko]

On Sun, Aug 7, 2022 at 4:50 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> I'm not sure how these slipped through my local tests and 0-day.
> These are definitely shown with W=1, perhaps not without that
> but IIO is generally W=1 clean.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Jonathan Cameron (2):
>   iio: test: Mark file local structure arrays static.
>   iio: light: cm32181: Mark the dev_pm_ops static.
>
>  drivers/iio/light/cm32181.c         | 2 +-
>  drivers/iio/test/iio-test-rescale.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.37.1
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/2] IIO: Clean up a couple of warnings that snuck in.

[Jonathan Cameron]

On Mon, 8 Aug 2022 11:15:52 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sun, Aug 7, 2022 at 4:50 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > I'm not sure how these slipped through my local tests and 0-day.
> > These are definitely shown with W=1, perhaps not without that
> > but IIO is generally W=1 clean.  
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied. Thanks,

Jonathan

> 
> > Jonathan Cameron (2):
> >   iio: test: Mark file local structure arrays static.
> >   iio: light: cm32181: Mark the dev_pm_ops static.
> >
> >  drivers/iio/light/cm32181.c         | 2 +-
> >  drivers/iio/test/iio-test-rescale.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > --
> > 2.37.1
> >  
> 
>