From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54ACAC25B08 for ; Sat, 20 Aug 2022 11:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232131AbiHTLLx (ORCPT ); Sat, 20 Aug 2022 07:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241900AbiHTLLw (ORCPT ); Sat, 20 Aug 2022 07:11:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1532082F99; Sat, 20 Aug 2022 04:11:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5D406112F; Sat, 20 Aug 2022 11:11:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4365FC433C1; Sat, 20 Aug 2022 11:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660993911; bh=y2vku3FvPEfhoYdiY4rx+MWU5/bKcGIj2zg4fjtZwDw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cfDBajFqZs2e5jtj1TVRYAWlgl/C7kQU5PFChAh8IJpnpCN/5P+F3RhJmgmkt/Mtv HUkiqt0GmzzaQ8+q/5nxxKqKe13ld6PlexUmE63OLTd3mWpgljCWR/ndsk9mO0iG1i 8b303WgAlYaQVCDggRWNBXlHi1eHw2PkUlxLjxWBgkQVJ+Zr801w+jf8PPgJgBX7nK RBgqOc0PAlJ2lWpXl/plS1imOt2ILBHDMjZ6+RWc20qXjrrN2/NL3Y0I3d2lqXGc5z YQmd+ud0rxT71I+9XZUfID7uuYERty50h8+GuIMMeIK++8XL0mlGVcFo1yxZPdQHUq 1sD8hcWYCkmKw== Date: Sat, 20 Aug 2022 12:22:26 +0100 From: Jonathan Cameron To: Matti Vaittinen Cc: Matti Vaittinen , Lars-Peter Clausen , Miaoqian Lin , Andy Shevchenko , Xiang wangx , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 08/14] iio: bmg160_core: Simplify using devm_regulator_*get_enable() Message-ID: <20220820122226.7f7d1b1a@jic23-huawei> In-Reply-To: <3fd11489356b1c73a3d7b4bd9dec7e12c9fe8788.1660934107.git.mazziesaccount@gmail.com> References: <3fd11489356b1c73a3d7b4bd9dec7e12c9fe8788.1660934107.git.mazziesaccount@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 19 Aug 2022 22:19:31 +0300 Matti Vaittinen wrote: > Use devm_regulator_bulk_get_enable() instead of open coded bulk-get, > bulk-enable, add-action-to-disable-at-detach - pattern. > > Signed-off-by: Matti Vaittinen > > --- > v2 => v3 > Split to own patch. > --- > drivers/iio/gyro/bmg160_core.c | 24 +++--------------------- > 1 file changed, 3 insertions(+), 21 deletions(-) > > diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c > index cedd9f02ea21..baa80980c99f 100644 > --- a/drivers/iio/gyro/bmg160_core.c > +++ b/drivers/iio/gyro/bmg160_core.c > @@ -93,7 +93,6 @@ > > struct bmg160_data { > struct regmap *regmap; > - struct regulator_bulk_data regulators[2]; > struct iio_trigger *dready_trig; > struct iio_trigger *motion_trig; > struct iio_mount_matrix orientation; > @@ -1067,19 +1066,13 @@ static const char *bmg160_match_acpi_device(struct device *dev) > return dev_name(dev); > } > > -static void bmg160_disable_regulators(void *d) > -{ > - struct bmg160_data *data = d; > - > - regulator_bulk_disable(ARRAY_SIZE(data->regulators), data->regulators); > -} > - > int bmg160_core_probe(struct device *dev, struct regmap *regmap, int irq, > const char *name) > { > struct bmg160_data *data; > struct iio_dev *indio_dev; > int ret; > + static const char * const regulators[] = {"vdd", "vddio"}; As in previous, small preference for spaces after { and before } > > indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); > if (!indio_dev) > @@ -1090,22 +1083,11 @@ int bmg160_core_probe(struct device *dev, struct regmap *regmap, int irq, > data->irq = irq; > data->regmap = regmap; > > - data->regulators[0].supply = "vdd"; > - data->regulators[1].supply = "vddio"; > - ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(data->regulators), > - data->regulators); > + ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulators), > + regulators); > if (ret) > return dev_err_probe(dev, ret, "Failed to get regulators\n"); > > - ret = regulator_bulk_enable(ARRAY_SIZE(data->regulators), > - data->regulators); > - if (ret) > - return ret; > - > - ret = devm_add_action_or_reset(dev, bmg160_disable_regulators, data); > - if (ret) > - return ret; > - > ret = iio_read_mount_matrix(dev, &data->orientation); > if (ret) > return ret;