From: Jonathan Cameron <jic23@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v4 2/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt
Date: Sat, 20 Aug 2022 12:50:49 +0100 [thread overview]
Message-ID: <20220820125049.4e35e721@jic23-huawei> (raw)
In-Reply-To: <f56c7486-2b78-48ac-3c5d-c7c20d1e78f5@linux.ibm.com>
On Mon, 15 Aug 2022 08:59:03 -0500
Eddie James <eajames@linux.ibm.com> wrote:
> On 8/12/22 17:13, Andy Shevchenko wrote:
> > On Wed, Aug 10, 2022 at 12:12 AM Eddie James <eajames@linux.ibm.com> wrote:
> >> Corruption of the MEAS_CFG register has been observed soon after
> >> system boot. In order to recover this scenario, check MEAS_CFG if
> >> measurement isn't ready, and if it's incorrect, reset the DPS310
> >> and execute the startup procedure.
> > Looks like both patches miss the Fixes tag. Can you add them?
>
>
> Well this isn't really a software fix - there's no identifiable bug in
> the driver. Just trying to recover the chip in this observed mystery
> scenario.
The tag is useful as well for where to backport this to.
Probably just tag the driver introduction.
Your description makes it clear we aren't finding faults in the
driver - just that it didn't cover this undocumented case!
Jonathan
prev parent reply other threads:[~2022-08-20 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 21:12 [PATCH v4 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt Eddie James
2022-08-09 21:12 ` [PATCH v4 1/2] iio: pressure: dps310: Refactor startup procedure Eddie James
2022-08-12 22:03 ` Andy Shevchenko
2022-08-15 13:42 ` Eddie James
2022-08-19 9:42 ` Andy Shevchenko
2022-08-20 11:49 ` Jonathan Cameron
2022-09-06 19:48 ` Eddie James
2022-09-11 9:56 ` Jonathan Cameron
2022-08-09 21:12 ` [PATCH v4 2/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt Eddie James
2022-08-12 22:13 ` Andy Shevchenko
2022-08-15 13:59 ` Eddie James
2022-08-20 11:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820125049.4e35e721@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).