Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joe Simmons-Talbott <joetalbott@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: Avoid multiple line dereference for mask
Date: Sat, 20 Aug 2022 13:17:54 +0100	[thread overview]
Message-ID: <20220820131754.729d59a9@jic23-huawei> (raw)
In-Reply-To: <20220819182012.219523-1-joetalbott@gmail.com>

On Fri, 19 Aug 2022 14:20:12 -0400
Joe Simmons-Talbott <joetalbott@gmail.com> wrote:

> Prefer lines > 80 characters over splitting dereferences across multiple
> lines. Reported by checkpatch.pl.
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@gmail.com>
Applied to the togreg branch of iio.git which will get pushed out initially
as testing for all the normal reasons...

Jonathan

> ---
> changes in v2:
> * Don't use a temporary variable.
> 
>  drivers/iio/industrialio-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 67d3d01d2dac..d38623c046cc 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1303,8 +1303,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,
>  
>  	ret = iio_device_add_info_mask_type_avail(indio_dev, chan,
>  						  IIO_SEPARATE,
> -						  &chan->
> -						  info_mask_separate_available);
> +						  &chan->info_mask_separate_available);
>  	if (ret < 0)
>  		return ret;
>  	attrcount += ret;
> @@ -1318,8 +1317,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,
>  
>  	ret = iio_device_add_info_mask_type_avail(indio_dev, chan,
>  						  IIO_SHARED_BY_TYPE,
> -						  &chan->
> -						  info_mask_shared_by_type_available);
> +						  &chan->info_mask_shared_by_type_available);
>  	if (ret < 0)
>  		return ret;
>  	attrcount += ret;


      reply	other threads:[~2022-08-20 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 18:20 [PATCH v2] iio: Avoid multiple line dereference for mask Joe Simmons-Talbott
2022-08-20 12:17 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220820131754.729d59a9@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=joetalbott@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox