From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4E2C0502A for ; Sun, 28 Aug 2022 17:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbiH1RHy (ORCPT ); Sun, 28 Aug 2022 13:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiH1RHw (ORCPT ); Sun, 28 Aug 2022 13:07:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E0B3137E; Sun, 28 Aug 2022 10:07:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE640B80B08; Sun, 28 Aug 2022 17:07:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E8DC433D6; Sun, 28 Aug 2022 17:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661706469; bh=iRCrcUJU/gdcFVVqwqMJvmG4wkdRzhFVjxK4n791U20=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r4c0E5/Ji1azkaovZcwAofgFC631PbBPee91aygbYDQ2zhS93ObIStJPRjn67B/BU Q3ZiRREfnNnMNJApa5NRnh67pIpY4i0XuGBqEC6AysNoBll4IsEUlbYZysS5ostMCr Ry6Avzrbl32RqXfSh/ra2LzIg3hn478mX0WtECvyg9rQTn1R1wkNvFy+4eve+l2Z0I EaiRiRh2f7FuFQUI1dq/o440wSmqGNP6dDo6nMn06roMmOcDBQ9bqcFUq3ZCPK+aqZ wdYtJQYH4RHIQZXKImML++XSgIMnVBnp1SLix6qcfOFdl4tBJjZ0epU9OuOZSBOriR EImG3L+L9/STg== Date: Sun, 28 Aug 2022 17:33:27 +0100 From: Jonathan Cameron To: Shreeya Patel Cc: lars@metafoo.de, krisman@collabora.com, dmitry.osipenko@collabora.com, kernel@collabora.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] iio: light: tsl2583: Fix module unloading Message-ID: <20220828173327.7949ad73@jic23-huawei> In-Reply-To: <20220826122352.288438-1-shreeya.patel@collabora.com> References: <20220826122352.288438-1-shreeya.patel@collabora.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 26 Aug 2022 17:53:52 +0530 Shreeya Patel wrote: > tsl2583 uses devm_iio_device_register() function and > calling iio_device_unregister() in remove breaks the > module unloading. > Fix this by using iio_device_register() instead of > devm_iio_device_register() function in probe. Not sure why you are wrapping at 55 chars. I rewrapped this whilst applying. Reworded it a little too as I was touching it anyway. Applied to the fixes-togreg branch of iio.git. > > Cc: stable@vger.kernel.org > Fixes: 371894f5d1a0 ("iio: tsl2583: add runtime power management support") I took a look at this patch and it introduces the issue I just pointed out in replying to your v1 by dropping the /* Make sure the chip is on */ Which was correct even with runtime pm because it covered the case of runtime_pm being disabled. We probably need to bring that back as well, perhaps as part of a cleanup patch taking this fully devm_ This driver has another issue for working if runtime PM isn't built into the kernel which is that it checks the return of pm_runtime_put_autosuspend() which calls static inline int __pm_runtime_suspend(struct device *dev, int rpmflags) { return -ENOSYS; } I've been meaning to do an audit for drivers that have this problem for a while, but not yet gotten to it. An ideal IIO driver needs to work correctly whether or not CONFIG_PM is enabled. Jonathan > Signed-off-by: Shreeya Patel > --- > Changes in v2 > - Use iio_device_register() instead of devm_iio_device_register() > - Add fixes and stable tags > > drivers/iio/light/tsl2583.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c > index 82662dab87c0..94d75ec687c3 100644 > --- a/drivers/iio/light/tsl2583.c > +++ b/drivers/iio/light/tsl2583.c > @@ -858,7 +858,7 @@ static int tsl2583_probe(struct i2c_client *clientp, > TSL2583_POWER_OFF_DELAY_MS); > pm_runtime_use_autosuspend(&clientp->dev); > > - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); > + ret = iio_device_register(indio_dev); > if (ret) { > dev_err(&clientp->dev, "%s: iio registration failed\n", > __func__);