From: Jonathan Cameron <jic23@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jagath Jog J <jagathjog1996@gmail.com>,
linux-iio@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH] iio: accel: bma400: Fix smatch warning based on use of unintialized value.
Date: Mon, 19 Sep 2022 16:41:04 +0100 [thread overview]
Message-ID: <20220919164104.46dc5f1a@jic23-huawei> (raw)
In-Reply-To: <YygH7FZ23HioBZGH@kadam>
On Mon, 19 Sep 2022 09:10:52 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sun, Sep 18, 2022 at 06:45:03PM +0100, Jonathan Cameron wrote:
> > On Sun, 18 Sep 2022 20:05:48 +0530
> > Jagath Jog J <jagathjog1996@gmail.com> wrote:
> >
> > > Hi Jonathan,
> > >
> > > Thank you for sending this patch.
> > > If you need a tag for this fix.
> > >
> > > Fixes: 961db2da159d ("iio: accel: bma400: Add support for single and
> > > double tap events")
> > Good point. I'm careful about fixes tags to stuff still not upstream
> > because they tend to be a little unstable. This should be fine.
> > I'll see if it's valid when I rebase the tree (hopefully in a few days
> > time).
>
> If you forget to update the tags after a rebase then Stephen Rothwell
> will let you know. It's best to not make Stephen's job more difficult,
> but it's some comfort to know that mistakes will get caught.
>
> regards,
> dan carpenter
>
Hi Dan,
Having messed this up and caused Stephen pointless work several times I now
have scripting (thanks to Greg KH's scripts and some local modes to make
sure the tag is in the upstream of the fix) to check this but some how
I still mess it up from time to time :(
Jonathan
next prev parent reply other threads:[~2022-09-19 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 13:14 [PATCH] iio: accel: bma400: Fix smatch warning based on use of unintialized value Jonathan Cameron
2022-09-18 14:35 ` Jagath Jog J
2022-09-18 17:45 ` Jonathan Cameron
2022-09-19 6:10 ` Dan Carpenter
2022-09-19 15:41 ` Jonathan Cameron [this message]
2022-09-18 18:20 ` Jagath Jog J
2022-09-19 16:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919164104.46dc5f1a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=glider@google.com \
--cc=jagathjog1996@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox