From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF2DECAAD3 for ; Mon, 19 Sep 2022 15:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbiISPw7 (ORCPT ); Mon, 19 Sep 2022 11:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbiISPw6 (ORCPT ); Mon, 19 Sep 2022 11:52:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D025132B81 for ; Mon, 19 Sep 2022 08:52:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68D8C61724 for ; Mon, 19 Sep 2022 15:52:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33921C433D6; Mon, 19 Sep 2022 15:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663602776; bh=d6L6gEfrGBr9oriVCLv9ZdBbit0qeffE+mEx6GTtCUo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kDXWgBn0mZLM365aRStYacqUH6LHJlEiXYCrtLLhNEGMWkyuyfZP8G0kdq8DU4//g 6vf1of8OsGuyjBHdTLFjsMuadIAxRsWvusubIapempoAr7cIAkW6o6MdIPEgsvjxbo xVAQ2skt9PGV1FTWqIBFmGxVRvH4aNuO797PIKq71eCNOk6fsrKjBdRt3gjhadZyQj m1Iq8NOflVeYC5wV7PpPFZH4WDFAOqefN6tG0nZuEIuB1EO+MZFwO3e0dQvXXW/zCK TFSdXuJhWrCYG8a7rp2cAch1Gdqc6W+erQBe587p/2mPEXQfQOCcVo6P4jeKOq145I KcvoyrDobFGOw== Date: Mon, 19 Sep 2022 16:53:00 +0100 From: Jonathan Cameron To: Wei Yongjun Cc: Lars-Peter Clausen , Wei Yongjun , Michael Hennerich , Subject: Re: [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings Message-ID: <20220919165300.71e8012f@jic23-huawei> In-Reply-To: References: <20220919145945.823327-1-weiyongjun@huaweicloud.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 19 Sep 2022 22:50:35 +0800 Wei Yongjun wrote: > On 2022/9/19 22:46, Lars-Peter Clausen wrote: > > On 9/19/22 16:59, Wei Yongjun wrote: > >> From: Wei Yongjun Hi Wei Yongjun, > >> > >> Add spi_device_id entries to silent following SPI warnings: silence rather than silent (also in patch titles) > >> > >> SPI driver ad7124 has no spi_device_id for adi,ad7124-4 > >> SPI driver ad7124 has no spi_device_id for adi,ad7124-8 > > What generates those warnings? > > > > Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT > compatible") added a test to check that every SPI driver has a > spi_device_id for each DT compatiable string defined by the driver > and warns if the spi_device_id is missing. When sending a series of similar fixes to a given subsystem together it's helpful to group them into a series, so that comments that apply series wide can easily be easily found. A cover letter is also useful to provide a little more information on what is being fixed. > > Regards, > Wei Yongjun