From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2715EECAAD3 for ; Mon, 19 Sep 2022 16:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbiISQEO (ORCPT ); Mon, 19 Sep 2022 12:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiISQDs (ORCPT ); Mon, 19 Sep 2022 12:03:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FADB13E85 for ; Mon, 19 Sep 2022 09:02:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21D5061551 for ; Mon, 19 Sep 2022 16:02:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 910B8C433C1; Mon, 19 Sep 2022 16:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663603348; bh=FGQ4eMVPI+svVp5BcrG88hFV6YmjZHrNQxo96180fN8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eQNrjFHPjsNNXfBUfyTbkpk/tF6tUjTUO5lHXDpOPO+APV0UXePGDoc2S+1KJ/zBI 0fYVNsIz9wOUfCGrk9eFulBngfnpopDBUoR1T+vIM2Ok12P0wi9JDEBb7XXlA+d6Hw F8nJ/1IrxtXEeeXFFaCPbGLXKXsZlD8aNjQDAuFWJTtGCyUKYNjgStvSIOlIbnU6bM o8WE/9NU4KbRRUDwOmXgBvBdq25aqXVnS6I00p7Ud2/8Vf0Zh9TpuBUU7MdgmnICfo v0TV3pa05NxSWTlvKtlJAmwEISHcTzXqx87PPlwhoTj2WKq2cncAjTHN3qk3Y5zRO4 yqMbcQtBeNmRw== Date: Mon, 19 Sep 2022 17:02:32 +0100 From: Jonathan Cameron To: Wei Yongjun Cc: Lars-Peter Clausen , LI Qingwu , Tomas Melin , Nuno =?UTF-8?B?U8Oh?= , Wei Yongjun , linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: accel: sca3300: Silent no spi_device_id warning Message-ID: <20220919170232.549ca9f6@jic23-huawei> In-Reply-To: <20220919150019.823401-1-weiyongjun@huaweicloud.com> References: <20220919150019.823401-1-weiyongjun@huaweicloud.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 19 Sep 2022 15:00:18 +0000 Wei Yongjun wrote: > From: Wei Yongjun Hi Wei Yongjun "Silence" rather than "Silent" in the patch title. > > Add spi_device_id entries to silent following SPI warning: silence Please add the extra info that Lars asked for to all these patches: the main aim here is to ensure driver module autoloading works. Code in this patch is fine. Jonathan > > SPI driver sca3300 has no spi_device_id for murata,scl3300 > > Signed-off-by: Wei Yongjun > --- > drivers/iio/accel/sca3300.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/accel/sca3300.c b/drivers/iio/accel/sca3300.c > index eaa0c9cfda44..693fbe8d6cb9 100644 > --- a/drivers/iio/accel/sca3300.c > +++ b/drivers/iio/accel/sca3300.c > @@ -679,12 +679,20 @@ static const struct of_device_id sca3300_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, sca3300_dt_ids); > > +static const struct spi_device_id sca3300_ids[] = { > + { "sca3300" }, > + { "scl3300" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(spi, sca3300_ids); > + > static struct spi_driver sca3300_driver = { > - .driver = { > + .driver = { > .name = SCA3300_ALIAS, > .of_match_table = sca3300_dt_ids, > }, > - .probe = sca3300_probe, > + .probe = sca3300_probe, > + .id_table = sca3300_ids, > }; > module_spi_driver(sca3300_driver); >