From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07A5C54EE9 for ; Mon, 19 Sep 2022 16:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbiISQFf (ORCPT ); Mon, 19 Sep 2022 12:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbiISQFN (ORCPT ); Mon, 19 Sep 2022 12:05:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7DC013DC9 for ; Mon, 19 Sep 2022 09:05:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5194961CB5 for ; Mon, 19 Sep 2022 16:05:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 113A0C433D6; Mon, 19 Sep 2022 16:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663603503; bh=1ibtes+qz3isp36e409ez6KN84ocvbwzusWlttGSIyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=efrHBgOoZ2RSk5Pjtk8mHqlrpEz/uZZkKLYkHjOlibu1jhQQHgBtx2rYTRbNnWGqW B5rguYDiIRrgOGjIAVNvQ3S7SAkJtDt6Od0OYxM8lrHE1/Ofw1BAvB5XG87O2ge6wm 1nXNjR08jNealfYLTO4SPnY3fT9jhVJUgW9orFVz9RSblo282QrtDHChcmv2oXuFu/ WqjOUP+jLJsvhODwZitMWO/gB/qPBFLdVzGQHWMNtgJKXtFmSThkbhYi8IgHye8t5M ykOG5uAFB6m4iuAd0dkE0BNV7yxI0py+pLTSWXx9ecTDxnR/f57E2YXka8VWGfM+qg B0VJoH6XGnX5A== Date: Mon, 19 Sep 2022 17:05:07 +0100 From: Jonathan Cameron To: Wei Yongjun Cc: Lars-Peter Clausen , Wei Yongjun , Michael Hennerich , Subject: Re: [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings Message-ID: <20220919170507.283601d5@jic23-huawei> In-Reply-To: References: <20220919145945.823327-1-weiyongjun@huaweicloud.com> <20220919165300.71e8012f@jic23-huawei> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 19 Sep 2022 23:55:56 +0800 Wei Yongjun wrote: > On 2022/9/19 23:53, Jonathan Cameron wrote: > > On Mon, 19 Sep 2022 22:50:35 +0800 > > Wei Yongjun wrote: > > > >> On 2022/9/19 22:46, Lars-Peter Clausen wrote: > >>> On 9/19/22 16:59, Wei Yongjun wrote: > >>>> From: Wei Yongjun > > Hi Wei Yongjun, > > > >>>> > >>>> Add spi_device_id entries to silent following SPI warnings: > > > > silence rather than silent (also in patch titles) > > > >>>> > >>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-4 > >>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-8 > >>> What generates those warnings? > >>> > >> > >> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT > >> compatible") added a test to check that every SPI driver has a > >> spi_device_id for each DT compatiable string defined by the driver > >> and warns if the spi_device_id is missing. > > > > When sending a series of similar fixes to a given subsystem together > > it's helpful to group them into a series, so that comments that > > apply series wide can easily be easily found. > > > > A cover letter is also useful to provide a little more information on > > what is being fixed. > > > Sure, will update in v3. On that note. It's a good idea to let a patch series, even when simple, sit for at least a few days before sending a new version. As demonstrated here you run the risk of going through multiple rounds just because reviews haven't come in yet! Reviewers will often not look at all at a series showing rapid version changes, because they take the view it's not yet stable and it will be more productive to review it once it is... Jonathan > > Thanks. >