From: Jonathan Cameron <jic23@kernel.org>
To: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Cc: <linux-iio@vger.kernel.org>, <Nuno.Sa@analog.com>,
<Nurettin.Bolucu@analog.com>
Subject: Re: [PATCH v5 1/3] iio: adc: add max11410 adc driver
Date: Sat, 24 Sep 2022 15:11:30 +0100 [thread overview]
Message-ID: <20220924151130.53afd007@jic23-huawei> (raw)
In-Reply-To: <20220920152628.285-2-Ibrahim.Tilki@analog.com>
On Tue, 20 Sep 2022 18:26:26 +0300
Ibrahim Tilki <Ibrahim.Tilki@analog.com> wrote:
> Adding support for max11410 24-bit, 1.9ksps delta-sigma adc which
> has 3 differential reference and 10 differential channel inputs.
> Inputs and references can be buffered internally. Inputs can also
> be amplified with internal PGA.
>
> Device has four digital filter modes: FIR50/60, FIR50, FIR60 and SINC4.
> FIR 50Hz and 60Hz rejections can be enabled/disabled separately.
> Digital filter selection affects sampling frequency range so driver
> has to consider the configured filter when configuring sampling frequency.
>
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Given we'll have a v6 to try and resolve the open question on the
binding, I may take another look, but on this look through
the driver looked very good to me, so no comments to address on this
patch or patch 3.
Jonathan
next prev parent reply other threads:[~2022-09-24 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:26 [PATCH v5 0/3] iio: adc: add max11410 adc driver Ibrahim Tilki
2022-09-20 15:26 ` [PATCH v5 1/3] " Ibrahim Tilki
2022-09-24 14:11 ` Jonathan Cameron [this message]
2022-09-20 15:26 ` [PATCH v5 2/3] dt-bindings: iio: adc: add adi,max11410.yaml Ibrahim Tilki
2022-09-24 14:01 ` Jonathan Cameron
2022-09-20 15:26 ` [PATCH v5 3/3] Documentation: ABI: testing: add max11410 doc Ibrahim Tilki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924151130.53afd007@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Nurettin.Bolucu@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox