From: "Mårten Lindahl" <marten.lindahl@axis.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: "Paul Cercueil" <paul@crapouillou.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-iio@vger.kernel.org, kernel@axis.com,
"Mårten Lindahl" <marten.lindahl@axis.com>
Subject: [PATCH v3 0/2] Add ps_it attributes for vcnl4040
Date: Mon, 26 Sep 2022 11:18:58 +0200 [thread overview]
Message-ID: <20220926091900.1724105-1-marten.lindahl@axis.com> (raw)
Currently there is no way for userspace to make any configuration of
the VCNL4040 sensors, but only the sensor readings are exported in
sysfs. To support configuration for proximity integration time value,
sysfs attributes for this needs to be exported.
To begin with the runtime power management turns both sensors (ALS, and
PS) on before reading the sensor register values and then switches
them off again. But when doing so it writes the whole register instead
of just switching the power on/off bit. This needs to be fixed in order
to make other persistent configurations.
Kind regards
Mårten Lindahl
Changes in v3:
- Rename defines for ALS/PS shutdown bits
- Add local variable for building register value
Changes in v2:
- Removed unnecessary switch for chip id
- Guard read/write sequence against potential race
- Remove confusing boolean operation
- Use bitmask macros instead of local field shifting
- Use .read_avail callback instead of using IIO_CONST_ATTR
- Skip [PATCH 2/3] iio: light: vcnl4000: Add enable attributes for vcnl4040
Mårten Lindahl (2):
iio: light: vcnl4000: Preserve conf bits when toggle power
iio: light: vcnl4000: Add ps_it attributes for vcnl4040
drivers/iio/light/vcnl4000.c | 185 +++++++++++++++++++++++++++++++++--
1 file changed, 179 insertions(+), 6 deletions(-)
--
2.30.2
next reply other threads:[~2022-09-26 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 9:18 Mårten Lindahl [this message]
2022-09-26 9:18 ` [PATCH v3 1/2] iio: light: vcnl4000: Preserve conf bits when toggle power Mårten Lindahl
2022-09-26 9:19 ` [PATCH v3 2/2] iio: light: vcnl4000: Add ps_it attributes for vcnl4040 Mårten Lindahl
2022-11-07 7:47 ` [PATCH v3 0/2] " Marten Lindahl
2022-11-07 16:44 ` Jonathan Cameron
2022-11-07 22:53 ` Marten Lindahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926091900.1724105-1-marten.lindahl@axis.com \
--to=marten.lindahl@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox