Re: [PATCH -next] iio: multiplexer: Switch to use dev_err_probe() helper

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 27 Sep 2022 14:48:41 +0800
Yang Yingliang <yangyingliang@huawei.com> wrote:

> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied to the togreg branch of iio.git. Now 6.2 material so I won't push
that branch out until I can rebase on 6.1-rc1

Jonathan

> ---
>  drivers/iio/multiplexer/iio-mux.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index 93558fddfa9b..edd8c69f6d2e 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -416,11 +416,9 @@ static int mux_probe(struct platform_device *pdev)
>  	}
>  
>  	mux->control = devm_mux_control_get(dev, NULL);
> -	if (IS_ERR(mux->control)) {
> -		if (PTR_ERR(mux->control) != -EPROBE_DEFER)
> -			dev_err(dev, "failed to get control-mux\n");
> -		return PTR_ERR(mux->control);
> -	}
> +	if (IS_ERR(mux->control))
> +		return dev_err_probe(dev, PTR_ERR(mux->control),
> +				     "failed to get control-mux\n");
>  
>  	i = 0;
>  	for (state = 0; state < all_children; state++) {