* [PATCH -next] iio: multiplexer: Switch to use dev_err_probe() helper
@ 2022-09-27 6:48 Yang Yingliang
2022-10-02 12:48 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-09-27 6:48 UTC (permalink / raw)
To: linux-iio; +Cc: peda, jic23, lars, Jonathan.Cameron, yangyingliang
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/iio/multiplexer/iio-mux.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index 93558fddfa9b..edd8c69f6d2e 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -416,11 +416,9 @@ static int mux_probe(struct platform_device *pdev)
}
mux->control = devm_mux_control_get(dev, NULL);
- if (IS_ERR(mux->control)) {
- if (PTR_ERR(mux->control) != -EPROBE_DEFER)
- dev_err(dev, "failed to get control-mux\n");
- return PTR_ERR(mux->control);
- }
+ if (IS_ERR(mux->control))
+ return dev_err_probe(dev, PTR_ERR(mux->control),
+ "failed to get control-mux\n");
i = 0;
for (state = 0; state < all_children; state++) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] iio: multiplexer: Switch to use dev_err_probe() helper
2022-09-27 6:48 [PATCH -next] iio: multiplexer: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-10-02 12:48 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-10-02 12:48 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-iio, peda, lars, Jonathan.Cameron
On Tue, 27 Sep 2022 14:48:41 +0800
Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied to the togreg branch of iio.git. Now 6.2 material so I won't push
that branch out until I can rebase on 6.1-rc1
Jonathan
> ---
> drivers/iio/multiplexer/iio-mux.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index 93558fddfa9b..edd8c69f6d2e 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -416,11 +416,9 @@ static int mux_probe(struct platform_device *pdev)
> }
>
> mux->control = devm_mux_control_get(dev, NULL);
> - if (IS_ERR(mux->control)) {
> - if (PTR_ERR(mux->control) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get control-mux\n");
> - return PTR_ERR(mux->control);
> - }
> + if (IS_ERR(mux->control))
> + return dev_err_probe(dev, PTR_ERR(mux->control),
> + "failed to get control-mux\n");
>
> i = 0;
> for (state = 0; state < all_children; state++) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-02 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-27 6:48 [PATCH -next] iio: multiplexer: Switch to use dev_err_probe() helper Yang Yingliang
2022-10-02 12:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).