Re: [PATCH v2 16/16] iio: core: move 'mlock' to 'struct iio_dev_opaque'

Nuno Sá
2022-10-10T07:47:56Z

On Sun, 2022-10-09 at 13:19 +0100, Jonathan Cameron wrote:
> On Tue, 4 Oct 2022 15:49:09 +0200
> Nuno Sá <nuno.sa@analog.com> wrote:
>
> > Now that there are no more users accessing 'mlock' directly, we can
> > move
> > it to the iio_dev private structure. Hence, it's now explicit that
> > new
> > driver's should not directly this lock.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> This looks good to me.
> So series wise, I think I've picked up 1-12.
> To resolve is remaining discussion plus the missmatch in function
> name vs
> comment in 13.
>

So, I think we are missing an improvement on the commit message for
patch 14 (about shadowing the error code) and fixing the function
name..
> Thanks for getting this tidied up!  It's the end of a very long
> process.
> I almost feel like we need a party - there would be a quite a crowd
> given
> how many people have been involved in this effort over the years. :)
>

Sure, happy to help! This one felt like something that we really need
to take care :)

- Nuno Sá