From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0F0C4332F for ; Sun, 16 Oct 2022 16:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbiJPQPI (ORCPT ); Sun, 16 Oct 2022 12:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbiJPQPF (ORCPT ); Sun, 16 Oct 2022 12:15:05 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B13B15A33; Sun, 16 Oct 2022 09:15:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8C0C4CE0B75; Sun, 16 Oct 2022 16:15:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AF06C433C1; Sun, 16 Oct 2022 16:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665936900; bh=x3CwrcunJNuG98FQOYXz8XlmpGAm0KMCZ85BHWC6tE8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nEJaXWhhd2AbXxqTB/M3bbJkH+pMZqcec9yhNtf8IaI6Zn1gGTE/tK20yBFZWBHqb GOITFK2LHrHlOwmtkhIzIioUzZNViQvXaOK88LFvZLU2SqGZElO2e6GwNKwLJCvbJS pqT+gyW+R3UqcYSutZand2saPmIBsWe3yNAnjm3ND1dvAE1osvSAqNiwxX2aPahYU2 LuxRP4hR7GkHEalI62xPxkzqmECdRy/HLgPI93Ld3WcKoq7bG0QC/c9i1KTRn78AHA DqMik2H4GbUi6MPDi/Ql0Pj47+KILZjKfarosKN8PuP2vGnIogauCpMZNZz57/wAGG n0rWeBRoALFRQ== Date: Sun, 16 Oct 2022 17:15:29 +0100 From: Jonathan Cameron To: Matti Vaittinen Cc: "Sa, Nuno" , Matti Vaittinen , Lars-Peter Clausen , "Hennerich, Michael" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 11/14] iio: ad7606: simplify using devm_regulator_get_enable() Message-ID: <20221016171520.07506844@jic23-huawei> In-Reply-To: <0aaeb018-94ba-eaaa-4000-7ad082a09850@gmail.com> References: <521c52f5a9bdc2db04d5775b36df4b233ae338da.1660934107.git.mazziesaccount@gmail.com> <0aaeb018-94ba-eaaa-4000-7ad082a09850@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 30 Aug 2022 15:54:07 +0300 Matti Vaittinen wrote: > Thanks for the review(s) Nuno! >=20 > On 8/30/22 14:46, Sa, Nuno wrote: > >> From: Matti Vaittinen > >> Sent: Friday, August 19, 2022 9:20 PM > >> To: Matti Vaittinen ; Matti Vaittinen > >> > >> Cc: Lars-Peter Clausen ; Hennerich, Michael > >> ; Jonathan Cameron > >> ; linux-iio@vger.kernel.org; linux- > >> kernel@vger.kernel.org > >> Subject: [PATCH v3 11/14] iio: ad7606: simplify using > >> devm_regulator_get_enable() > >> > >> [External] > >> > >> Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > >> add_action_or_reset(regulator_disable)' and use the > >> devm_regulator_get_enable() and drop the pointer to the regulator. > >> This simplifies code and makes it less tempting to add manual control > >> for the regulator which is also controlled by devm. > >> > >> Signed-off-by: Matti Vaittinen > >> > >> --- =20 > >=20 > > The commit message could state that while doing the change, dev_err_pro= be() > > was also introduced. Bah, anyways: > >=20 > > Acked-by: Nuno S=C3=A1 =20 >=20 > Good point. I have few other changes to the series pending - and I=20 > probably need to rebase/respin when -rc1 is out (and dependency patches=20 > are merged from Mark's tree) =3D> I may as well alter the commit message. >=20 I tweaked it and applied. Not I'm grabbing these early because I forgot you'd sent them and found myself writing the same patches. Memory of a goldfish :) Jonathan > Yours, > -- Matti >=20