From: Jonathan Cameron <jic23@kernel.org>
To: Yauhen Kharuzhy <jekhor@gmail.com>
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH] HID: hid-sensor-custom: Allow more than one hinge angle sensor
Date: Sun, 6 Nov 2022 17:36:43 +0000 [thread overview]
Message-ID: <20221106173643.5b4f2a0b@jic23-huawei> (raw)
In-Reply-To: <20221105223422.417316-1-jekhor@gmail.com>
On Sun, 6 Nov 2022 00:34:22 +0200
Yauhen Kharuzhy <jekhor@gmail.com> wrote:
> Some devices has two sets of accelerometers and the sensor hub exports
> two hinge angle 'sensors' based on accelerometer values. To allow more
> than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of
> PLATFORM_DEVID_NONE when registering platform device for it.
>
> Checked on the Lenovo Yoga Book YB1-X91L tablet.
>
> Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
Purely for curiosity sake, but where are the two sets of sensors?
Doesn't look like it has two hinges at first glance!
Jonathan
> ---
> drivers/hid/hid-sensor-custom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
> index 32c2306e240d6..a6fc89ee1287c 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
> return ERR_PTR(-ENOMEM);
>
> custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
> - PLATFORM_DEVID_NONE, hsdev,
> + PLATFORM_DEVID_AUTO, hsdev,
> sizeof(*hsdev));
> kfree(dev_name);
> return custom_pdev;
next prev parent reply other threads:[~2022-11-06 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 22:34 [PATCH] HID: hid-sensor-custom: Allow more than one hinge angle sensor Yauhen Kharuzhy
2022-11-06 17:36 ` Jonathan Cameron [this message]
2022-11-06 19:58 ` Yauhen Kharuzhy
2022-11-12 15:49 ` Jonathan Cameron
2022-11-12 16:09 ` srinivas pandruvada
2022-11-14 14:01 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106173643.5b4f2a0b@jic23-huawei \
--to=jic23@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jekhor@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox