From: Jonathan Cameron <jic23@kernel.org>
To: Edmund Berenson <edmund.berenson@emlix.com>
Cc: Lukasz Zemla <Lukasz.Zemla@woodward.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio/adc: add ad7927 compatibility to ad7923 drivers
Date: Wed, 16 Nov 2022 19:10:56 +0000 [thread overview]
Message-ID: <20221116191056.59f901da@jic23-huawei> (raw)
In-Reply-To: <20221116104453.3207-1-edmund.berenson@emlix.com>
On Wed, 16 Nov 2022 11:44:52 +0100
Edmund Berenson <edmund.berenson@emlix.com> wrote:
> The ADC ad7927 is compatible with ad7923 driver,
> add explicit compatible and select appropriate
> channel configuration.
>
> Suggested-by: Lukasz Zemla <Lukasz.Zemla@woodward.com>
> Signed-off-by: Edmund Berenson <edmund.berenson@emlix.com>
This should match local style for patch formatting (as with the
dt one that has already been commented on).
iio: adc: ad7928: Add ad7927
The ad7927 is software compatible with the existing AD7928
so just add the ID.
S...
Change itself is fine.
> ---
> drivers/iio/adc/ad7923.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> index 9d6bf6d0927a..df72e97dc331 100644
> --- a/drivers/iio/adc/ad7923.c
> +++ b/drivers/iio/adc/ad7923.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7928 SPI ADC driver
> + * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7927/AD7928 SPI ADC driver
> *
> * Copyright 2011 Analog Devices Inc (from AD7923 Driver)
> * Copyright 2012 CS Systemes d'Information
> @@ -367,6 +367,7 @@ static const struct spi_device_id ad7923_id[] = {
> {"ad7924", AD7924},
> {"ad7908", AD7908},
> {"ad7918", AD7918},
> + {"ad7927", AD7928},
> {"ad7928", AD7928},
> {}
> };
> @@ -379,6 +380,7 @@ static const struct of_device_id ad7923_of_match[] = {
> { .compatible = "adi,ad7924", },
> { .compatible = "adi,ad7908", },
> { .compatible = "adi,ad7918", },
> + { .compatible = "adi,ad7927", },
> { .compatible = "adi,ad7928", },
> { },
> };
next prev parent reply other threads:[~2022-11-16 18:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 10:44 [PATCH 1/2] iio/adc: add ad7927 compatibility to ad7923 drivers Edmund Berenson
2022-11-16 10:44 ` [PATCH 2/2] iio/adc: add documentation for adc ad7927 Edmund Berenson
2022-11-16 11:13 ` Krzysztof Kozlowski
2022-11-16 19:12 ` Jonathan Cameron
2022-11-20 12:45 ` [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation Edmund Berenson
2022-11-20 15:09 ` Rob Herring
2022-11-20 15:34 ` Rob Herring
2022-11-20 17:06 ` [PATCH v3] " Edmund Berenson
2022-11-21 9:13 ` Krzysztof Kozlowski
2022-11-21 10:26 ` Edmund Berenson
2022-11-21 10:31 ` Krzysztof Kozlowski
2022-11-21 10:45 ` Edmund Berenson
2022-11-21 11:15 ` Krzysztof Kozlowski
2022-11-21 12:45 ` Jonathan Cameron
2022-11-21 16:16 ` Krzysztof Kozlowski
2022-11-16 19:10 ` Jonathan Cameron [this message]
2022-11-20 12:42 ` [PATCH v2 1/2] iio: adc: ad7923: Add ad7927 Edmund Berenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116191056.59f901da@jic23-huawei \
--to=jic23@kernel.org \
--cc=Lukasz.Zemla@woodward.com \
--cc=Michael.Hennerich@analog.com \
--cc=edmund.berenson@emlix.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox