Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PULL] IIO: First set of new device support, features and cleanup for 6.2
Date: Wed, 23 Nov 2022 20:12:29 +0000	[thread overview]
Message-ID: <20221123201229.225964a0@jic23-huawei> (raw)
In-Reply-To: <20221123194918.3d523e97@jic23-huawei>

On Wed, 23 Nov 2022 19:49:18 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 23 Nov 2022 19:40:56 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Nov 16, 2022 at 07:03:08PM +0000, Jonathan Cameron wrote:  
> > > The following changes since commit 30a0b95b1335e12efef89dd78518ed3e4a71a763:
> > > 
> > >   Linux 6.1-rc3 (2022-10-30 15:19:28 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-6.2a    
> > 
> > I get the following error when trying to push these out:
> > 
> > Commit: 3acdb4a11517 ("iio: adc: ad_sigma_delta: do not use internal iio_dev lock")
> > 	Fixes tag: Fixes: af3008485ea0 ("iio:adc: Add common code for ADI Sigma Deltadevices")
> > 	Has these problem(s):
> > 		- Subject does not match target commit subject
> > 		 Just use
> > 			git log -1 --format='Fixes: %h ("%s")'
> > 
> > 
> > linux-next should have also warned of this, right?  
> 
> It didn't... Or the email got eaten by something (maybe me)
> Sorry about that.
> 
> Jonathan
> > 
> > Can you fix this up and resend?  
> 
> Coming right up - assuming I don't mess up rebasing.

Gah. I hate fixes tags sometimes (on the plus side I do like your script
for checking them which I'd obviously failed to run on the very first patch
on my tree for some reason). 6 others were broken as a result of the
rebase to fix this one and needed manual repair.

Anyhow, fingers crossed v2 is in better shape. Thankfully everything I have
queued for a second pull request so far hasn't had fixes tags.
I plan to let the second set have a few days in Linux next before sending
another (hopefully better!) final pull request for 6.2 stuff.

Thanks as ever for your help and one day I'll get this right first time every
time :(

Jonathan

> 
> > 
> > thanks,
> > 
> > greg k-h  
> 


      reply	other threads:[~2022-11-23 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 19:03 [PULL] IIO: First set of new device support, features and cleanup for 6.2 Jonathan Cameron
2022-11-23 18:40 ` Greg KH
2022-11-23 19:49   ` Jonathan Cameron
2022-11-23 20:12     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123201229.225964a0@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox