From: Jonathan Cameron <jic23@kernel.org>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: addac: ad74115: remove unused ad74115_dac_slew_rate_hz_tbl
Date: Thu, 24 Nov 2022 19:25:52 +0000 [thread overview]
Message-ID: <20221124192552.144e8348@jic23-huawei> (raw)
In-Reply-To: <20221124152559.7895-1-cosmin.tanislav@analog.com>
On Thu, 24 Nov 2022 17:25:59 +0200
Cosmin Tanislav <demonsingur@gmail.com> wrote:
> This table was supposed to be used for handling the DAC rate, but it
> ended up being unused. Remove it.
>
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 48ea75598db2 ("iio: addac: add AD74115 driver")
Dropped fixes tag as it's not going to do anything bad other than warning
without this and to put it likely fixes tags against recent patches have
been causing me a world of pain this week.
Applied on basis its safe enough even without time soaking in next.
Jonathan
> ---
> drivers/iio/addac/ad74115.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
> index 383b92e7b682..e6bc5eb3788d 100644
> --- a/drivers/iio/addac/ad74115.c
> +++ b/drivers/iio/addac/ad74115.c
> @@ -317,10 +317,6 @@ static const unsigned int ad74115_dac_rate_step_tbl[][3] = {
> { AD74115_SLEW_MODE_LINEAR, AD74115_SLEW_STEP_22_2_PERCENT, AD74115_SLEW_RATE_240KHZ },
> };
>
> -static const unsigned int ad74115_dac_slew_rate_hz_tbl[] = {
> - 4000, 64000, 150000, 240000
> -};
> -
> static const unsigned int ad74115_rtd_excitation_current_ua_tbl[] = {
> 250, 500, 750, 1000
> };
prev parent reply other threads:[~2022-11-24 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 15:25 [PATCH] iio: addac: ad74115: remove unused ad74115_dac_slew_rate_hz_tbl Cosmin Tanislav
2022-11-24 19:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124192552.144e8348@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=demonsingur@gmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox