From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F3C4C4321E for ; Sun, 4 Dec 2022 14:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbiLDOPA (ORCPT ); Sun, 4 Dec 2022 09:15:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbiLDOO5 (ORCPT ); Sun, 4 Dec 2022 09:14:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD7F16489 for ; Sun, 4 Dec 2022 06:14:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E909860E00 for ; Sun, 4 Dec 2022 14:14:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D80E5C433C1; Sun, 4 Dec 2022 14:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670163294; bh=LAgsXLX28aWgpbVLA5cmQLopihBVJWWySyKT3xtcXmw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tbWEn0HI1I56bOgM384loMhYK8wq6deBUXuHLoLYK4QeVmNnwZfX/wbzL+L+n5+D8 bzBmmdKrcAmsnzxZt8SxDuJvW/JrnNhJNID7Qj3+KSg0zv8apBRH0nEG/jfz8tKmK7 rr5Sz+WpOrp43gDyJbmpdfemG/9ZCvpJWzuWwJVNAeyozJMU19YDUhjX9Ao7ffaNcq NHSQWdh4V22QxxeV6xJQfpwjIcN4BN8JVPgNYH9CKRRJS8CPRitQRdtvOMogvXMGar qGiVwRuv7KwX06+kaJlKQGaX93YoOy9n9HVPSe0yfwl0A3IJHSXueTbB8aiCglTUxH c/CsemKDoukgg== Date: Sun, 4 Dec 2022 14:27:40 +0000 From: Jonathan Cameron To: Xiongfeng Wang Cc: , , , , Subject: Re: [PATCH] iio: adc: berlin2-adc: Add missing of_node_put() in error path Message-ID: <20221204142740.56a46ef9@jic23-huawei> In-Reply-To: <20221129020316.191731-1-wangxiongfeng2@huawei.com> References: <20221129020316.191731-1-wangxiongfeng2@huawei.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 29 Nov 2022 10:03:16 +0800 Xiongfeng Wang wrote: > of_get_parent() will return a device_node pointer with refcount > incremented. We need to use of_node_put() on it when done. Add the > missing of_node_put() in the error path of berlin2_adc_probe(); > > Fixes: 70f1937911ca ("iio: adc: add support for Berlin") > Signed-off-by: Xiongfeng Wang Applied. Thanks, Jonathan > --- > drivers/iio/adc/berlin2-adc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/berlin2-adc.c b/drivers/iio/adc/berlin2-adc.c > index 3d2e8b4db61a..a4e7c7eff5ac 100644 > --- a/drivers/iio/adc/berlin2-adc.c > +++ b/drivers/iio/adc/berlin2-adc.c > @@ -298,8 +298,10 @@ static int berlin2_adc_probe(struct platform_device *pdev) > int ret; > > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv)); > - if (!indio_dev) > + if (!indio_dev) { > + of_node_put(parent_np); > return -ENOMEM; > + } > > priv = iio_priv(indio_dev); >