From: Andreas Kemnade <andreas@kemnade.info>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, jiasheng@iscas.ac.cn, paul@crapouillou.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] iio:adc:twl6030: Enable measurements of VUSB, VBAT and others
Date: Sun, 4 Dec 2022 21:27:51 +0100 [thread overview]
Message-ID: <20221204212751.2de52084@aktux> (raw)
In-Reply-To: <20221204154152.5f7948b9@jic23-huawei>
On Sun, 4 Dec 2022 15:41:52 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Thu, 1 Dec 2022 19:16:35 +0100
> Andreas Kemnade <andreas@kemnade.info> wrote:
>
> > Some inputs need to be wired up to produce proper measurements,
> > without this change only near zero values are reported.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> Sounds like a fix to me. If so, Fixes tag?
seems to be there since the beginning, to it would be
Fixes: 1696f36482e70 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
I think it was just not used with the charger (which is not in mainline yet),
so it was probably ignored.
>
> Anything in here we should be turning off again if the driver is removed
> or toggling on suspend? If not, other than the space below this looks fine to me.
>
I would consider that as configuration, comparing with the nearest relative twl4030,
there a similar bit is set in the probe() without disabling it in the remove().
But I think we should set TWL6030_GPADCR in remove() as we do in suspend(),
but that is another fix.
Regards,
Andreas
next prev parent reply other threads:[~2022-12-04 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 18:16 [PATCH] iio:adc:twl6030: Enable measurements of VUSB, VBAT and others Andreas Kemnade
2022-12-04 15:41 ` Jonathan Cameron
2022-12-04 20:27 ` Andreas Kemnade [this message]
2022-12-11 11:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204212751.2de52084@aktux \
--to=andreas@kemnade.info \
--cc=jiasheng@iscas.ac.cn \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).