* [PATCH] iio: st_sensors: Convert to use sysfs_emit_at() API
@ 2022-12-07 7:53 ye.xingchen
2022-12-11 12:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-12-07 7:53 UTC (permalink / raw)
To: jic23
Cc: lars, andriy.shevchenko, miquel.raynal, nuno.sa, wsa+renesas,
linux-iio, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/common/st_sensors/st_sensors_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
index c77d7bdcc121..44e374f84197 100644
--- a/drivers/iio/common/st_sensors/st_sensors_core.c
+++ b/drivers/iio/common/st_sensors/st_sensors_core.c
@@ -628,8 +628,7 @@ ssize_t st_sensors_sysfs_sampling_frequency_avail(struct device *dev,
if (sdata->sensor_settings->odr.odr_avl[i].hz == 0)
break;
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
- sdata->sensor_settings->odr.odr_avl[i].hz);
+ len += sysfs_emit_at(buf, len, "%d ", sdata->sensor_settings->odr.odr_avl[i].hz);
}
buf[len - 1] = '\n';
@@ -651,7 +650,7 @@ ssize_t st_sensors_sysfs_scale_avail(struct device *dev,
q = sdata->sensor_settings->fs.fs_avl[i].gain / 1000000;
r = sdata->sensor_settings->fs.fs_avl[i].gain % 1000000;
- len += scnprintf(buf + len, PAGE_SIZE - len, "%u.%06u ", q, r);
+ len += sysfs_emit_at(buf, len, "%u.%06u ", q, r);
}
buf[len - 1] = '\n';
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: st_sensors: Convert to use sysfs_emit_at() API
2022-12-07 7:53 [PATCH] iio: st_sensors: Convert to use sysfs_emit_at() API ye.xingchen
@ 2022-12-11 12:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-12-11 12:15 UTC (permalink / raw)
To: ye.xingchen
Cc: lars, andriy.shevchenko, miquel.raynal, nuno.sa, wsa+renesas,
linux-iio, linux-kernel
On Wed, 7 Dec 2022 15:53:55 +0800 (CST)
<ye.xingchen@zte.com.cn> wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index c77d7bdcc121..44e374f84197 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -628,8 +628,7 @@ ssize_t st_sensors_sysfs_sampling_frequency_avail(struct device *dev,
> if (sdata->sensor_settings->odr.odr_avl[i].hz == 0)
> break;
>
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> - sdata->sensor_settings->odr.odr_avl[i].hz);
> + len += sysfs_emit_at(buf, len, "%d ", sdata->sensor_settings->odr.odr_avl[i].hz);
Another case where I would prefer we keep the line break.
> }
> buf[len - 1] = '\n';
>
> @@ -651,7 +650,7 @@ ssize_t st_sensors_sysfs_scale_avail(struct device *dev,
> q = sdata->sensor_settings->fs.fs_avl[i].gain / 1000000;
> r = sdata->sensor_settings->fs.fs_avl[i].gain % 1000000;
>
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%u.%06u ", q, r);
> + len += sysfs_emit_at(buf, len, "%u.%06u ", q, r);
> }
> buf[len - 1] = '\n';
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-11 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 7:53 [PATCH] iio: st_sensors: Convert to use sysfs_emit_at() API ye.xingchen
2022-12-11 12:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).