Re: [PATCH] iio: light: max44009: Convert to i2c's .probe_new()

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 22 Dec 2022 15:54:29 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> since the series that mass converted drivers to probe_new this driver
> was added with the old probe prototype. Fix is accordingly.

Nope, this driver has been there since 2019.  It's the one that I failed
to pick up your patch for originally.  I have it queued up for the coming
cycle, but not pushed out for next yet because I want to rebase my tree
on rc1 first.

Jonathan

> 
> Best regards
> Uwe
> 
>  drivers/iio/light/max44009.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c
> index 801e5a0ad496..3dadace09fe2 100644
> --- a/drivers/iio/light/max44009.c
> +++ b/drivers/iio/light/max44009.c
> @@ -487,8 +487,7 @@ static irqreturn_t max44009_threaded_irq_handler(int irq, void *p)
>  	return IRQ_NONE;
>  }
>  
> -static int max44009_probe(struct i2c_client *client,
> -			  const struct i2c_device_id *id)
> +static int max44009_probe(struct i2c_client *client)
>  {
>  	struct max44009_data *data;
>  	struct iio_dev *indio_dev;
> @@ -538,7 +537,7 @@ static struct i2c_driver max44009_driver = {
>  	.driver = {
>  		.name = MAX44009_DRV_NAME,
>  	},
> -	.probe = max44009_probe,
> +	.probe_new = max44009_probe,
>  	.id_table = max44009_id,
>  };
>  module_i2c_driver(max44009_driver);
> 
> base-commit: 9d2f6060fe4c3b49d0cdc1dce1c99296f33379c8