Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lars@metafoo.de, paul@crapouillou.net, jiasheng@iscas.ac.cn,
	oleksandr.kozaruk@ti.com, gg@slimlogic.co.uk, balajitk@ti.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] iio:adc:twl6030: Enable measurement of VAC
Date: Fri, 23 Dec 2022 16:02:00 +0000	[thread overview]
Message-ID: <20221223160200.1ae6df91@jic23-huawei> (raw)
In-Reply-To: <20221217221305.671117-1-andreas@kemnade.info>

On Sat, 17 Dec 2022 23:13:05 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

> VAC needs to be wired up to produce proper measurements,
> without this change only near zero values are reported.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 40438e5b4970..32873fb5f367 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
> -				VBAT_MEAS | BB_MEAS | BB_MEAS,
> +				VBAT_MEAS | BB_MEAS | VAC_MEAS,
>  				TWL6030_MISC1);
>  	if (ret < 0) {
>  		dev_err(dev, "failed to wire up inputs\n");


      reply	other threads:[~2022-12-23 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 22:13 [PATCH] iio:adc:twl6030: Enable measurement of VAC Andreas Kemnade
2022-12-23 16:02 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223160200.1ae6df91@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=balajitk@ti.com \
    --cc=gg@slimlogic.co.uk \
    --cc=jiasheng@iscas.ac.cn \
    --cc=julia.lawall@lip6.fr \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oleksandr.kozaruk@ti.com \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox