From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78900C4332F for ; Thu, 29 Dec 2022 09:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbiL2JV3 (ORCPT ); Thu, 29 Dec 2022 04:21:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbiL2JV1 (ORCPT ); Thu, 29 Dec 2022 04:21:27 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4CE5DEC9; Thu, 29 Dec 2022 01:21:26 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id bs20so14792899wrb.3; Thu, 29 Dec 2022 01:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gV8zkytSIxFdA1gfddCUQSfndGX/x2fwl4EcvCd27uo=; b=gZIsGvTVIPkVBreWBZUqhG6tJ6TQG/e2nkgRlmxPFjOZP3sWE7Mzh9ZnzHltkfeagl vNa7GNSmuzK26wHYU75od9NuT1Zx9+xElfsnGR48kkHxt2Wn1/WVap2O51ualnbvHQBS fESS6Wf9aT2G7FSepKTHQqM7cY5afjA6mCvk+X2J2BQUYz+Aoe/nzPbW1zLfRKeYjku9 M9GOp3NZqPsnIxfTx54yojHYlxRlvsjfbq0VgoZ+z2pXjXDrZHxC+KKusAhujwnoxzxr ueR6whlLnAyAZ7rUbjHL2RtY74zNHGQvv+vdFyCMLrz3HcrmM9F3qz/qtZTsA0Pr+Fa5 p5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gV8zkytSIxFdA1gfddCUQSfndGX/x2fwl4EcvCd27uo=; b=pDgXWoGiUM5JMHSQINEJXuTdz31up+0gmBjvUrzd3on6O48oEUvaOQvgw5cBMPeWnm EFKnCYoY0XEbheXStzZszzt7TJDH38CAalemKoV4seR3utt00adrscmgtkyY8y/Bc/Gp ba6GR5mTq65jdtCCMaK/y9kZb9c75W1iPrLyE6cM29RnUnjvkRtpQeQAEtWIXKplELbn YqfLXqot94tF7AvQYylzbcrXPoik0g1lP+zVxunJQAPk6d0hbriuYQZ45Jm/Ze4u7Z8M y4v1ECOk1AT/uw1gmqxhMQtFSfQaK9VCgX+KDLHbDoly/eygypUNmMAQnPalAFpI413m Uh/Q== X-Gm-Message-State: AFqh2kpg5ApMfuA7Y4m0RqN9yJHiOqvqS+GdGYugiy4hBbnS55gPezQ+ 61M9++l9w25J8TH3QklNPZQ= X-Google-Smtp-Source: AMrXdXu8uslP5kkZ6Op0IWp56ubHVeC5h/fhOMnfLfNmq5qDVaWBUav0s0f9JohP1U3b8gcCl9ti1Q== X-Received: by 2002:a5d:6210:0:b0:236:695b:82d4 with SMTP id y16-20020a5d6210000000b00236695b82d4mr16636511wru.30.1672305685076; Thu, 29 Dec 2022 01:21:25 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id m18-20020a05600c3b1200b003a6125562e1sm26483603wms.46.2022.12.29.01.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 01:21:24 -0800 (PST) Date: Thu, 29 Dec 2022 12:20:44 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Angel Iglesias , linux-iio@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Angel Iglesias , Jonathan Cameron , Lars-Peter Clausen , Nikita Yushchenko , Andy Shevchenko , Ulf Hansson , "Rafael J. Wysocki" , Paul Cercueil , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] iio: pressure: bmp280: Add support for new sensor BMP580 Message-ID: <202212260352.XQTIlVGl-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a1c9341102fdce2f49d151f0cba76f1ba9ba279.1671986815.git.ang.iglesiasg@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Angel, url: https://github.com/intel-lab-lkp/linux/commits/Angel-Iglesias/iio-pressure-bmp280-Add-enumeration-to-handle-chip-variants/20221226-010158 base: e807541c2b273677e82ef50b5747ec7ae7d652b9 patch link: https://lore.kernel.org/r/5a1c9341102fdce2f49d151f0cba76f1ba9ba279.1671986815.git.ang.iglesiasg%40gmail.com patch subject: [PATCH 3/5] iio: pressure: bmp280: Add support for new sensor BMP580 config: i386-randconfig-m021-20221226 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter smatch warnings: drivers/iio/pressure/bmp280-core.c:1654 bmp580_preinit() warn: missing error code? 'ret' vim +/ret +1654 drivers/iio/pressure/bmp280-core.c ce037d81e52ecb Angel Iglesias 2022-12-25 1631 static int bmp580_preinit(struct bmp280_data *data) ce037d81e52ecb Angel Iglesias 2022-12-25 1632 { ce037d81e52ecb Angel Iglesias 2022-12-25 1633 unsigned int reg; ce037d81e52ecb Angel Iglesias 2022-12-25 1634 int ret; ce037d81e52ecb Angel Iglesias 2022-12-25 1635 ce037d81e52ecb Angel Iglesias 2022-12-25 1636 /* Issue soft-reset command */ ce037d81e52ecb Angel Iglesias 2022-12-25 1637 ret = bmp580_cmd(data, BMP580_SOFT_RESET_CMD); ce037d81e52ecb Angel Iglesias 2022-12-25 1638 if (ret) ce037d81e52ecb Angel Iglesias 2022-12-25 1639 return ret; ce037d81e52ecb Angel Iglesias 2022-12-25 1640 /* Post powerup sequence */ ce037d81e52ecb Angel Iglesias 2022-12-25 1641 ret = regmap_read(data->regmap, BMP580_REG_CHIP_ID, ®); ce037d81e52ecb Angel Iglesias 2022-12-25 1642 if (ret) ce037d81e52ecb Angel Iglesias 2022-12-25 1643 return ret; ce037d81e52ecb Angel Iglesias 2022-12-25 1644 if (reg != BMP580_CHIP_ID) { ce037d81e52ecb Angel Iglesias 2022-12-25 1645 dev_err(data->dev, "preinit: unexpected chip_id\n"); ce037d81e52ecb Angel Iglesias 2022-12-25 1646 return ret; ce037d81e52ecb Angel Iglesias 2022-12-25 1647 } ce037d81e52ecb Angel Iglesias 2022-12-25 1648 ret = regmap_read(data->regmap, BMP580_REG_STATUS, ®); ce037d81e52ecb Angel Iglesias 2022-12-25 1649 if (ret) ce037d81e52ecb Angel Iglesias 2022-12-25 1650 return ret; ce037d81e52ecb Angel Iglesias 2022-12-25 1651 /* Check nvm status */ ce037d81e52ecb Angel Iglesias 2022-12-25 1652 if (!(reg & BMP580_STATUS_NVM_RDY_MASK) || (reg & BMP580_STATUS_NVM_ERR_MASK)) { ce037d81e52ecb Angel Iglesias 2022-12-25 1653 dev_err(data->dev, "preinit: nvm error on powerup sequence\n"); ce037d81e52ecb Angel Iglesias 2022-12-25 @1654 return ret; "ret" is zero. It should be return -EINVAL or something. ce037d81e52ecb Angel Iglesias 2022-12-25 1655 } ce037d81e52ecb Angel Iglesias 2022-12-25 1656 ce037d81e52ecb Angel Iglesias 2022-12-25 1657 return 0; ce037d81e52ecb Angel Iglesias 2022-12-25 1658 } -- 0-DAY CI Kernel Test Service https://01.org/lkp