From: Jonathan Cameron <jic23@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: linux-iio@vger.kernel.org, Lorenzo Bianconi <lorenzo@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m
Date: Sun, 8 Jan 2023 12:15:40 +0000 [thread overview]
Message-ID: <20230108121540.461f4c0c@jic23-huawei> (raw)
In-Reply-To: <20230103130348.1733467-1-vladimir.oltean@nxp.com>
On Tue, 3 Jan 2023 15:03:48 +0200
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> The following kernel linkage error:
>
> st_lsm6dsx_core.o: in function `st_lsm6dsx_sw_buffers_setup':
> st_lsm6dsx_core.c:2578: undefined reference to `devm_iio_triggered_buffer_setup_ext'
>
> is caused by the fact that the object owning devm_iio_triggered_buffer_setup_ext()
> (drivers/iio/buffer/industrialio-triggered-buffer.o) is allowed to be
> built as module when its user (drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c)
> is built-in.
>
> The st_lsm6dsx driver already has a "select IIO_BUFFER", so add another
> select for IIO_TRIGGERED_BUFFER, to make that option follow what is set
> for the st_lsm6dsx driver. This is similar to what other iio drivers do.
>
> Fixes: 2cfb2180c3e8 ("iio: imu: st_lsm6dsx: introduce sw trigger support")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/imu/st_lsm6dsx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> index f6660847fb58..8c16cdacf2f2 100644
> --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> @@ -4,6 +4,7 @@ config IIO_ST_LSM6DSX
> tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
> depends on (I2C || SPI || I3C)
> select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> select IIO_KFIFO_BUF
> select IIO_ST_LSM6DSX_I2C if (I2C)
> select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
prev parent reply other threads:[~2023-01-08 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 13:03 [PATCH] iio: imu: st_lsm6dsx: fix build when CONFIG_IIO_TRIGGERED_BUFFER=m Vladimir Oltean
2023-01-08 12:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108121540.461f4c0c@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox