From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Perchanov <dmitry.perchanov@intel.com>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, demisrael@gmail.com
Subject: Re: [PATCH] iio: hid: fix the retval in accel_3d_capture_sample
Date: Sat, 14 Jan 2023 16:30:42 +0000 [thread overview]
Message-ID: <20230114163042.55f89318@jic23-huawei> (raw)
In-Reply-To: <a6dc426498221c81fa71045b41adf782ebd42136.camel@intel.com>
On Wed, 11 Jan 2023 14:22:10 +0200
Dmitry Perchanov <dmitry.perchanov@intel.com> wrote:
> Return value should be zero for success.
> This was forgotten for timestamp feature.
> Verified on RealSense cameras.
>
> Fixes: a96cd0f901ee ("iio: accel: hid-sensor-accel-3d: Add timestamp")
>
All tags need to be in one block with no blank lines. I've fixed
this up whilst applying. Applied to the fixes-togreg branch of iio.git.
Thanks
Jonathan
> Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
> ---
> drivers/iio/accel/hid-sensor-accel-3d.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index a2def6f93..5eac7ea19 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -280,6 +280,7 @@ static int accel_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
> hid_sensor_convert_timestamp(
> &accel_state->common_attributes,
> *(int64_t *)raw_data);
> + ret = 0;
> break;
> default:
> break;
prev parent reply other threads:[~2023-01-14 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 12:22 [PATCH] iio: hid: fix the retval in accel_3d_capture_sample Dmitry Perchanov
2023-01-14 16:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114163042.55f89318@jic23-huawei \
--to=jic23@kernel.org \
--cc=demisrael@gmail.com \
--cc=dmitry.perchanov@intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox