From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Perchanov <dmitry.perchanov@intel.com>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, demisrael@gmail.com
Subject: Re: iio: hid: fix the retval in gyro_3d_capture_sample
Date: Sat, 14 Jan 2023 16:32:45 +0000 [thread overview]
Message-ID: <20230114163245.33a9f7fa@jic23-huawei> (raw)
In-Reply-To: <7c1809dc74eb2f58a20595f4d02e76934f8e9219.camel@intel.com>
On Wed, 11 Jan 2023 14:24:25 +0200
Dmitry Perchanov <dmitry.perchanov@intel.com> wrote:
> Return value should be zero for success.
> This was forgotten for timestamp feature.
> Verified on RealSense cameras.
>
> Fixes: 4648cbd8fb92 ("iio: hid-sensor-gyro-3d: Add timestamp channel")
>
> Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Applied with patch description white space tidied up (wrap at 75 chars,
not blank lines in tags block).
Applied to the fixes-togreg branch of iio.git and marked for stable
inclusion.
Thanks,
Jonathan
> ---
> drivers/iio/gyro/hid-sensor-gyro-3d.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index 8f0ad022c..698c50da1 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> @@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
> gyro_state->timestamp =
> hid_sensor_convert_timestamp(&gyro_state->common_attributes,
> *(s64 *)raw_data);
> + ret = 0;
> break;
> default:
> break;
prev parent reply other threads:[~2023-01-14 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 12:24 iio: hid: fix the retval in gyro_3d_capture_sample Dmitry Perchanov
2023-01-14 16:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114163245.33a9f7fa@jic23-huawei \
--to=jic23@kernel.org \
--cc=demisrael@gmail.com \
--cc=dmitry.perchanov@intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox