From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Barry Song <baohua@kernel.org>
Subject: [PATCH v2 00/12] staging: iio: accel: adis16203 Inclinometer cleanup and graduation
Date: Sun, 29 Jan 2023 15:55:50 +0000 [thread overview]
Message-ID: <20230129155602.740743-1-jic23@kernel.org> (raw)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
v2:
- Device tree binding docs fixes.
- --no-renames so that the whole driver is in the patch 11 email for
easy review of what I am proposing we move out of staging.
Whilst taking a look at what we still have in staging, I noticed that this
driver was (probably) only still there due to the need to define some ABI
for the odd 180 degree offset channel (same as the other channel
minus 180 degrees).
Rather than leaving the driver in staging for ever, let us just drop that
channel and move on. The rest of the series is trivial driver cleanup.
Note this is only build tested, so would be great if people can take
a good look. If anyone happens to have one of these that would be even
better (they are still marked for production use more than 12 years after
the driver was submitted).
There are lots of features we could support if anyone wanted to, but
it should be functional for basic channel reading without the bells
and whistles. I've tried to incorporate the relevant device tree bindings
however (multiple interrupt lines, supplies and reset gpio).
Cc: Barry Song <baohua@kernel.org>
(mostly for comedy value, not expecting you to remember the driver :)
Jonathan Cameron (12):
staging: iio: accel: adis16203: More conventional header ordering
staging: iio: accel: adis16203: Drop excessive register comments
staging: iio: accel: adis16203: Rename incli channel registers
staging: iio: accel: adis16203: Drop the 180 degree offset channel
staging: iio: accel: adis16203: Simplify handling of calibbias
staging: iio: accel: adis16203: Drop driver name define
staging: iio: accel: adis16203: Make units explicit in name of delay
define
staging: iio: accel: adis16203: Trivial whitespace cleanup
staging: iio: accel: adis16203: Drop setting drvdata as nothing gets
it
staging: iio: accel: adis16203: Trivial style cleanup
staging: iio: accel: adis16203: Move out of staging
dt-bindings: iio: accel: Add ADIS16203 Inclinometer
.../bindings/iio/accel/adi,adis16203.yaml | 64 ++++
drivers/iio/accel/Kconfig | 12 +
drivers/iio/accel/Makefile | 1 +
drivers/iio/accel/adis16203.c | 231 +++++++++++++
drivers/staging/iio/accel/Kconfig | 12 -
drivers/staging/iio/accel/Makefile | 1 -
drivers/staging/iio/accel/adis16203.c | 315 ------------------
7 files changed, 308 insertions(+), 328 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
create mode 100644 drivers/iio/accel/adis16203.c
delete mode 100644 drivers/staging/iio/accel/adis16203.c
--
2.39.1
next reply other threads:[~2023-01-29 15:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 15:55 Jonathan Cameron [this message]
2023-01-29 15:55 ` [PATCH v2 01/12] staging: iio: accel: adis16203: More conventional header ordering Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 02/12] staging: iio: accel: adis16203: Drop excessive register comments Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 03/12] staging: iio: accel: adis16203: Rename incli channel registers Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 04/12] staging: iio: accel: adis16203: Drop the 180 degree offset channel Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 05/12] staging: iio: accel: adis16203: Simplify handling of calibbias Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 06/12] staging: iio: accel: adis16203: Drop driver name define Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 07/12] staging: iio: accel: adis16203: Make units explicit in name of delay define Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 08/12] staging: iio: accel: adis16203: Trivial whitespace cleanup Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 09/12] staging: iio: accel: adis16203: Drop setting drvdata as nothing gets it Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 10/12] staging: iio: accel: adis16203: Trivial style cleanup Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 11/12] staging: iio: accel: adis16203: Move out of staging Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 12/12] dt-bindings: iio: accel: Add ADIS16203 Inclinometer Jonathan Cameron
2023-01-30 13:35 ` Rob Herring
2023-01-30 15:21 ` Rob Herring
2023-01-30 17:09 ` Jonathan Cameron
2023-01-30 17:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230129155602.740743-1-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=baohua@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).