From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v2 02/12] staging: iio: accel: adis16203: Drop excessive register comments
Date: Sun, 29 Jan 2023 15:55:52 +0000 [thread overview]
Message-ID: <20230129155602.740743-3-jic23@kernel.org> (raw)
In-Reply-To: <20230129155602.740743-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
A lot of these comments added very little that was not obvious
from the register/field name. In one case the polarity was the opposite
of what would be expected so rename that field (currently unused
in the driver)
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/staging/iio/accel/adis16203.c | 71 +--------------------------
1 file changed, 1 insertion(+), 70 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index dd02ceb00d40..60117aaf56d4 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -15,111 +15,42 @@
#define ADIS16203_STARTUP_DELAY 220 /* ms */
-/* Flash memory write count */
#define ADIS16203_FLASH_CNT 0x00
-
-/* Output, power supply */
#define ADIS16203_SUPPLY_OUT 0x02
-
-/* Output, auxiliary ADC input */
#define ADIS16203_AUX_ADC 0x08
-
-/* Output, temperature */
#define ADIS16203_TEMP_OUT 0x0A
-
-/* Output, x-axis inclination */
#define ADIS16203_XINCL_OUT 0x0C
-
-/* Output, y-axis inclination */
#define ADIS16203_YINCL_OUT 0x0E
-
-/* Incline null calibration */
#define ADIS16203_INCL_NULL 0x18
-
-/* Alarm 1 amplitude threshold */
#define ADIS16203_ALM_MAG1 0x20
-
-/* Alarm 2 amplitude threshold */
#define ADIS16203_ALM_MAG2 0x22
-
-/* Alarm 1, sample period */
#define ADIS16203_ALM_SMPL1 0x24
-
-/* Alarm 2, sample period */
#define ADIS16203_ALM_SMPL2 0x26
-
-/* Alarm control */
#define ADIS16203_ALM_CTRL 0x28
-
-/* Auxiliary DAC data */
#define ADIS16203_AUX_DAC 0x30
-
-/* General-purpose digital input/output control */
#define ADIS16203_GPIO_CTRL 0x32
-
-/* Miscellaneous control */
#define ADIS16203_MSC_CTRL 0x34
-
-/* Internal sample period (rate) control */
#define ADIS16203_SMPL_PRD 0x36
-
-/* Operation, filter configuration */
#define ADIS16203_AVG_CNT 0x38
-
-/* Operation, sleep mode control */
#define ADIS16203_SLP_CNT 0x3A
-
-/* Diagnostics, system status register */
#define ADIS16203_DIAG_STAT 0x3C
-
-/* Operation, system command register */
#define ADIS16203_GLOB_CMD 0x3E
-/* MSC_CTRL */
-
-/* Self-test at power-on: 1 = disabled, 0 = enabled */
-#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST BIT(10)
-
-/* Reverses rotation of both inclination outputs */
+#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST_DIS BIT(10)
#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN BIT(9)
-
-/* Self-test enable */
#define ADIS16203_MSC_CTRL_SELF_TEST_EN BIT(8)
-
-/* Data-ready enable: 1 = enabled, 0 = disabled */
#define ADIS16203_MSC_CTRL_DATA_RDY_EN BIT(2)
-
-/* Data-ready polarity: 1 = active high, 0 = active low */
#define ADIS16203_MSC_CTRL_ACTIVE_HIGH BIT(1)
-
-/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 BIT(0)
-/* DIAG_STAT */
-
-/* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
#define ADIS16203_DIAG_STAT_ALARM2 BIT(9)
-
-/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
#define ADIS16203_DIAG_STAT_ALARM1 BIT(8)
-
-/* Self-test diagnostic error flag */
#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5
-
-/* SPI communications failure */
#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3
-
-/* Flash update failure */
#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2
-
-/* Power supply above 3.625 V */
#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1
-
-/* Power supply below 2.975 V */
#define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0
-/* GLOB_CMD */
-
#define ADIS16203_GLOB_CMD_SW_RESET BIT(7)
#define ADIS16203_GLOB_CMD_CLEAR_STAT BIT(4)
#define ADIS16203_GLOB_CMD_FACTORY_CAL BIT(1)
--
2.39.1
next prev parent reply other threads:[~2023-01-29 15:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 15:55 [PATCH v2 00/12] staging: iio: accel: adis16203 Inclinometer cleanup and graduation Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 01/12] staging: iio: accel: adis16203: More conventional header ordering Jonathan Cameron
2023-01-29 15:55 ` Jonathan Cameron [this message]
2023-01-29 15:55 ` [PATCH v2 03/12] staging: iio: accel: adis16203: Rename incli channel registers Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 04/12] staging: iio: accel: adis16203: Drop the 180 degree offset channel Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 05/12] staging: iio: accel: adis16203: Simplify handling of calibbias Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 06/12] staging: iio: accel: adis16203: Drop driver name define Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 07/12] staging: iio: accel: adis16203: Make units explicit in name of delay define Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 08/12] staging: iio: accel: adis16203: Trivial whitespace cleanup Jonathan Cameron
2023-01-29 15:55 ` [PATCH v2 09/12] staging: iio: accel: adis16203: Drop setting drvdata as nothing gets it Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 10/12] staging: iio: accel: adis16203: Trivial style cleanup Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 11/12] staging: iio: accel: adis16203: Move out of staging Jonathan Cameron
2023-01-29 15:56 ` [PATCH v2 12/12] dt-bindings: iio: accel: Add ADIS16203 Inclinometer Jonathan Cameron
2023-01-30 13:35 ` Rob Herring
2023-01-30 15:21 ` Rob Herring
2023-01-30 17:09 ` Jonathan Cameron
2023-01-30 17:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230129155602.740743-3-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).