* [PATCH] iio: adis16480: select CONFIG_CRC32
@ 2023-01-31 9:46 Arnd Bergmann
2023-01-31 10:23 ` Nuno Sá
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-01-31 9:46 UTC (permalink / raw)
To: Jonathan Cameron, Nuno Sa, Lars-Peter Clausen
Cc: Arnd Bergmann, Andrea Merello, linux-iio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
In rare randconfig builds, the missing CRC32 helper causes
a link error:
ld.lld: error: undefined symbol: crc32_le
>>> referenced by usercopy_64.c
>>> vmlinux.o:(adis16480_trigger_handler)
Fixes: 941f130881fa ("iio: adis16480: support burst read function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/imu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/imu/Kconfig b/drivers/iio/imu/Kconfig
index f1d7d4b5e222..c2f97629e9cd 100644
--- a/drivers/iio/imu/Kconfig
+++ b/drivers/iio/imu/Kconfig
@@ -47,6 +47,7 @@ config ADIS16480
depends on SPI
select IIO_ADIS_LIB
select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
+ select CRC32
help
Say yes here to build support for Analog Devices ADIS16375, ADIS16480,
ADIS16485, ADIS16488 inertial sensors.
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adis16480: select CONFIG_CRC32
2023-01-31 9:46 [PATCH] iio: adis16480: select CONFIG_CRC32 Arnd Bergmann
@ 2023-01-31 10:23 ` Nuno Sá
2023-02-02 17:02 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Nuno Sá @ 2023-01-31 10:23 UTC (permalink / raw)
To: Arnd Bergmann, Jonathan Cameron, Nuno Sa, Lars-Peter Clausen
Cc: Arnd Bergmann, Andrea Merello, linux-iio, linux-kernel
On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In rare randconfig builds, the missing CRC32 helper causes
> a link error:
>
> ld.lld: error: undefined symbol: crc32_le
> > > > referenced by usercopy_64.c
> > > > vmlinux.o:(adis16480_trigger_handler)
>
> Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adis16480: select CONFIG_CRC32
2023-01-31 10:23 ` Nuno Sá
@ 2023-02-02 17:02 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2023-02-02 17:02 UTC (permalink / raw)
To: Nuno Sá
Cc: Arnd Bergmann, Nuno Sa, Lars-Peter Clausen, Arnd Bergmann,
Andrea Merello, linux-iio, linux-kernel
On Tue, 31 Jan 2023 11:23:10 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > In rare randconfig builds, the missing CRC32 helper causes
> > a link error:
> >
> > ld.lld: error: undefined symbol: crc32_le
> > > > > referenced by usercopy_64.c
> > > > > vmlinux.o:(adis16480_trigger_handler)
> >
> > Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
>
Applied to the fixes-togreg branch of iio.git and marked
for stable.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 9:46 [PATCH] iio: adis16480: select CONFIG_CRC32 Arnd Bergmann
2023-01-31 10:23 ` Nuno Sá
2023-02-02 17:02 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).