From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B420C636CC for ; Sun, 5 Feb 2023 14:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjBEOoC (ORCPT ); Sun, 5 Feb 2023 09:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjBEOoB (ORCPT ); Sun, 5 Feb 2023 09:44:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D38A94EE1 for ; Sun, 5 Feb 2023 06:44:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E6E6B80B8F for ; Sun, 5 Feb 2023 14:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EBA4C433D2; Sun, 5 Feb 2023 14:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675608238; bh=uPvx/Sr/4LFtrfRYeflvI/5ljIFpM0axYM+vSxFX+Bc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l4Cl+sJYxPCE0nAQg5Ym1lNTMoch6Kh1hNaX1D7CsBFvVezn7XFPfvz2/74o8qYEb cupN0KWs89M2mb731usaFvcxerPYVxFYy/4imWy0+N5ZyZOhMXY9GZrqTK9JfPCvJy jdVtIqDtHIXJlD8duEfZcPG5YjlsuJdmh+zsmZ9id5NIw3t6UxWW+dL/vhuU6vijQn aRrlUiOwS+eoIBFlyQ81eyvO6GkzRl/tWAIlxT7M2zCsHu+MKCDeCxwu8G9pfW4CPi aYNVNtvN/bLyIW0mqnqKnP+8nXhp3DYUTwOnM4JhPFPAIXOQhYIWeIS+OlhH/83ZCu oBKTfIxFWnoGg== Date: Sun, 5 Feb 2023 14:57:59 +0000 From: Jonathan Cameron To: Stephen Boyd Cc: Gwendal Grignou , linux-iio@vger.kernel.org Subject: Re: [PATCH v3] iio: proximity: sx_common: Add old register mapping Message-ID: <20230205145759.2ce9f274@jic23-huawei> In-Reply-To: References: <20230129003753.1980309-1-gwendal@chromium.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 30 Jan 2023 11:41:31 -0800 Stephen Boyd wrote: > Quoting Gwendal Grignou (2023-01-28 16:37:53) > > Older firmwares still send sensor configuration using a list of > > registers with opaque values defined during sensor tuning. > > sx9234 and sx9360 sensor on ACPI based devices are concerned. > > More schema to configure the sensors will be needed to support devices > > designed for windows, like Samsung Galaxy Book2. > > > > Support schema is: "<_HID>.". For instance > > "STH9324,reg_adv_ctrl2" in: > > > > Scope (\_SB.PCI0.I2C2) > > { > > Device (SX28) > > { > > Name (_HID, "STH9324") // _HID: Hardware ID > > ... > > Name (_DSD, Package (0x02) // _DSD: Device-Specific Data > > { > > ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* > > Device Properties for _DSD */, > > Package (0x3F) > > { > > ... > > Package (0x02) > > { > > "STH9324,reg_adv_ctrl2", > > Zero > > },` > > > > Signed-off-by: Gwendal Grignou > > --- > > Reviewed-by: Stephen Boyd Applied to the togreg branch of iio.git and pushed out as testing. Timing wise, we are late in the cycle so this might not make it upstream until next cycle. Thanks, Jonathan