Re: [PATCH] iio: imu: st_lsm6dsx: discard samples during filters settling time

[Philippe De Muyter <phdm@macq.eu>]

Hello Lorenzo,

On Sun, Feb 12, 2023 at 11:21:32AM +0100, Lorenzo Bianconi wrote:
> Date: Sun, 12 Feb 2023 11:21:32 +0100
> From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> To: Lorenzo Bianconi <lorenzo@kernel.org>
> Cc: jic23@kernel.org, phdm@macq.eu, linux-iio@vger.kernel.org
> Subject: Re: [PATCH] iio: imu: st_lsm6dsx: discard samples during filters
> 	settling time
> 
> > During digital filters settling time the driver is expected to drop
> > samples since they can be corrupted. Introduce the capability to drop
> > a given number of samples according to the configured ODR.
> > Add the sample_to_discard data for LSM6DSM sensor.
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h       | 11 ++++
> >  .../iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c    | 58 +++++++++++++++----
> >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c  | 18 ++++++
> >  3 files changed, 77 insertions(+), 10 deletions(-)
> 
> I forgot to say I tested this patch on my LSM6DSM and it works fine for me.
> 
> Regards,
> Lorenzo
> 

It works fine for me too, with a ism330dlc.

	Reported-by: Philippe De Muyter <phdm@macqel.be>
	Tested-by: Philippe De Muyter <phdm@macqel.be>

However I have another bug, with our without the patch : frequently
my test, using a loop around iio-generic-buffer, blocks on the poll syscall.
No value comes anymore.  This happens both with the gyro as with the accel
component.

More info follows.

Best regards

Philippe