From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Robert Eshleman <bobbyeshleman@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iio: proximity: sx9500: Reference ACPI and OF ID data
Date: Sun, 12 Mar 2023 16:18:53 +0000 [thread overview]
Message-ID: <20230312161853.55b5b317@jic23-huawei> (raw)
In-Reply-To: <20230312153429.371702-3-krzysztof.kozlowski@linaro.org>
On Sun, 12 Mar 2023 16:34:29 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> Always reference acpi_device_id and of_device_id tables, as they is
> little benefit of conditional compiling and OF table could be used also
> for ACPI matching via PRP0001. This fixes warning:
>
> drivers/iio/proximity/sx9500.c:1039:34: error: ‘sx9500_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
Applied
Thanks,
Jonathan
> Changes since v1:
> 1. Drop of_match_ptr and ACPI_PTR
> ---
> drivers/iio/proximity/sx9500.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
> index 8794e75e5bf9..9b2cfcade6a4 100644
> --- a/drivers/iio/proximity/sx9500.c
> +++ b/drivers/iio/proximity/sx9500.c
> @@ -1051,8 +1051,8 @@ MODULE_DEVICE_TABLE(i2c, sx9500_id);
> static struct i2c_driver sx9500_driver = {
> .driver = {
> .name = SX9500_DRIVER_NAME,
> - .acpi_match_table = ACPI_PTR(sx9500_acpi_match),
> - .of_match_table = of_match_ptr(sx9500_of_match),
> + .acpi_match_table = sx9500_acpi_match,
> + .of_match_table = sx9500_of_match,
> .pm = pm_sleep_ptr(&sx9500_pm_ops),
> },
> .probe_new = sx9500_probe,
next prev parent reply other threads:[~2023-03-12 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 15:34 [PATCH v2 1/3] iio: dac: ad5755: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-12 15:34 ` [PATCH v2 2/3] iio: light: max44009: add missing OF device matching Krzysztof Kozlowski
2023-03-12 16:18 ` Jonathan Cameron
2023-03-12 15:34 ` [PATCH v2 3/3] iio: proximity: sx9500: Reference ACPI and OF ID data Krzysztof Kozlowski
2023-03-12 16:18 ` Jonathan Cameron [this message]
2023-03-12 16:20 ` [PATCH v2 1/3] iio: dac: ad5755: mark OF related data as maybe unused Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312161853.55b5b317@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=bobbyeshleman@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox