From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0595BC74A5B for ; Thu, 16 Mar 2023 22:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbjCPWo7 (ORCPT ); Thu, 16 Mar 2023 18:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjCPWo6 (ORCPT ); Thu, 16 Mar 2023 18:44:58 -0400 X-Greylist: delayed 36099 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 16 Mar 2023 15:44:55 PDT Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [IPv6:2001:4b7a:2000:18::167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB39D52F40 for ; Thu, 16 Mar 2023 15:44:55 -0700 (PDT) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id D2DD2402E6; Thu, 16 Mar 2023 23:44:52 +0100 (CET) Date: Thu, 16 Mar 2023 23:44:50 +0100 From: Marijn Suijten To: Jonathan Cameron Cc: Jonathan Cameron , Rob Herring , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , iio@vger.kernel.org, Lars-Peter Clausen , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Dmitry Baryshkov , linux-pm@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name Message-ID: <20230316224450.onx2bldlisfwwp23@SoMainline.org> Mail-Followup-To: Marijn Suijten , Jonathan Cameron , Jonathan Cameron , Rob Herring , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , iio@vger.kernel.org, Lars-Peter Clausen , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Dmitry Baryshkov , linux-pm@vger.kernel.org References: <20230201204447.542385-1-marijn.suijten@somainline.org> <20230201204447.542385-3-marijn.suijten@somainline.org> <20230203212501.GA908601-robh@kernel.org> <20230205150645.549ff062@jic23-huawei> <20230316124307.pzuvbacsmjdootfx@SoMainline.org> <20230316174428.00003c4c@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316174428.00003c4c@Huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 2023-03-16 17:44:28, Jonathan Cameron wrote: > > Should it inherit the common binding, or was it omitted for a reason? > > Harmless but little point as far as I can see given we don't happen > to have any of the generic elements defined in the generic channel > binding. Supposedly the reg property, and now also the node name. Up to you to say whether I should inherit this (and strip out the common bits) or just focus on renaming the node name in the existing binding to channel. - Marijn