From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CB5C61DA4 for ; Sat, 18 Mar 2023 16:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbjCRQZy (ORCPT ); Sat, 18 Mar 2023 12:25:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjCRQZx (ORCPT ); Sat, 18 Mar 2023 12:25:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B12D5126F3 for ; Sat, 18 Mar 2023 09:25:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4366160E93 for ; Sat, 18 Mar 2023 16:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8D90C433EF; Sat, 18 Mar 2023 16:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679156751; bh=6R/1P2Quynr5mNcruOicXmQT70ahwWfQg9go4fzL1rM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EEKXFZNbwlRlDWj+6eh6KYWNvbbBAJ5OKPuPOFKPJVTmca9cY3liZ88vUi8zLFZ6/ 0EG3oNt0ZwytpF3MdlJ5SYhJbvQzHgu/vyuRI4GuR/bVAsiNsL1Gk+9jQKOJw8XV4V +n6aXHqXHI1aMPKd9//W2UnCzygPhOqPGjWEpzTptUNcnbraxeqptz9dD7F2WQwLqP BkQ+lEQjD6FcLk8CxzHa2YO/E3O8gej05TTw/1/7hh4wJ9/ioZ2ebX7BPEZS8JZ0QV YO0/iW7OtgFgODwDDSA/WcgFHCpJDFRBVV+b3nb1JuxQCIX9esz1zJetdPyJTWzdou JoBpkQ+Qqc+Wg== Date: Sat, 18 Mar 2023 16:40:45 +0000 From: Jonathan Cameron To: David Lechner Cc: Lars-Peter Clausen , Justin Chen , linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip Message-ID: <20230318164045.4a5f4d35@jic23-huawei> In-Reply-To: <603a73ae-5c67-0837-ed26-9a98ad3fec74@lechnology.com> References: <20230312210933.2275376-1-lars@metafoo.de> <603a73ae-5c67-0837-ed26-9a98ad3fec74@lechnology.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 13 Mar 2023 13:44:33 -0500 David Lechner wrote: > On 3/12/23 4:09 PM, Lars-Peter Clausen wrote: > > The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks. > > This means these callbacks can sleep and the `can_sleep` flag should be > > set. > > > > Having the flag set will make sure that warnings are generated when calling > > any of the callbacks from a potentially non-sleeping context. > > > > Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support") > > Signed-off-by: Lars-Peter Clausen > > --- > > Acked-by: David Lechner > > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan