From: Brian Masney <bmasney@redhat.com>
To: jic23@kernel.org
Cc: andriy.shevchenko@linux.intel.com, trix@redhat.com,
lars@metafoo.de, nathan@kernel.org, ndesaulniers@google.com,
u.kleine-koenig@pengutronix.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, hslester96@gmail.com
Subject: [PATCH] iio: light: tsl2772: fix reading proximity-diodes from device tree
Date: Mon, 3 Apr 2023 21:14:55 -0400 [thread overview]
Message-ID: <20230404011455.339454-1-bmasney@redhat.com> (raw)
tsl2772_read_prox_diodes() will correctly parse the properties from
device tree to determine which proximity diode(s) to read from, however
it didn't actually set this value on the struct tsl2772_settings. Let's
go ahead and fix that.
Reported-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/lkml/20230327120823.1369700-1-trix@redhat.com/
Fixes: 94cd1113aaa0 ("iio: tsl2772: add support for reading proximity led settings from device tree")
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
drivers/iio/light/tsl2772.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index ad50baa0202c..e823c145f679 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -601,6 +601,7 @@ static int tsl2772_read_prox_diodes(struct tsl2772_chip *chip)
return -EINVAL;
}
}
+ chip->settings.prox_diode = prox_diode_mask;
return 0;
}
--
2.39.2
next reply other threads:[~2023-04-04 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 1:14 Brian Masney [this message]
2023-04-04 7:13 ` [PATCH] iio: light: tsl2772: fix reading proximity-diodes from device tree kernel test robot
2023-04-04 11:13 ` Brian Masney
2023-04-04 12:35 ` Uwe Kleine-König
2023-04-04 22:36 ` Brian Masney
2023-04-08 9:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404011455.339454-1-bmasney@redhat.com \
--to=bmasney@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hslester96@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox