From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E71C77B70 for ; Sat, 15 Apr 2023 16:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbjDOQjk (ORCPT ); Sat, 15 Apr 2023 12:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjDOQjj (ORCPT ); Sat, 15 Apr 2023 12:39:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4678421B for ; Sat, 15 Apr 2023 09:39:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8030E60ADF for ; Sat, 15 Apr 2023 16:39:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20659C433D2; Sat, 15 Apr 2023 16:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681576777; bh=m12Wojvj0aAZam7vE4eThYvhDPLzJEnY7nKdrJZREDk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kbmb944mXF/staDCdoolg0nNt/9ePRmvAo0kgi2YO0ygM52yBtBe/bThF6OooqZuj VMLpKrhVIZmM0kNBMAVlBpVxiD35ocwecWqLEwKqA9nOPpUhsI4k94o966AEzuFVu9 Yd4cXXLGcwkH/1Gz3+Qx+ySagRLuuFDrBFSpGNlZXDqGjlO4UOwG8q0i03IWh0l8IX ZvP34LV8sXpawSeFXnPltJ6alTbdYnyhIIUxefNMo0Ki157yhZtlOuEeTrkvyxnkYT SX5pTeBAR5KVF0g4CsqV4jDcSt/tqJi6IOTcpmus9wMwvP6eu1iGpV50zjwSRuXnbW uxXWM+CwNo78w== Date: Sat, 15 Apr 2023 17:39:39 +0100 From: Jonathan Cameron To: Fabrizio Lamarque Cc: linux-iio@vger.kernel.org, Nuno =?UTF-8?B?U8Oh?= Subject: Re: [PATCH 2/3] iio: adc: ad7192: Fix internal/external clock selection Message-ID: <20230415173939.3c2dc829@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 13 Apr 2023 10:33:32 +0200 Fabrizio Lamarque wrote: > Fixed wrong selection of internal clock when mclk is defined. > > Resolved a logical inversion introduced in c9ec2cb328e3. > > Fixes: c9ec2cb328e3 iio: adc: ad7192: use devm_clk_get_optional() for mclk > Signed-off-by: Fabrizio Lamarque Version should apply to whole series. git format-patch -v2 is a good way to get this right automatically. Patch is fine subject to the fixes tag fix that Nuno pointed out. Thanks, Jonathan > --- > drivers/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > index 94a9cf34a255..5a9c8898f8af 100644 > --- a/drivers/iio/adc/ad7192.c > +++ b/drivers/iio/adc/ad7192.c > @@ -367,7 +367,7 @@ static int ad7192_of_clock_select(struct ad7192_state *st) > clock_sel = AD7192_CLK_INT; > > /* use internal clock */ > - if (st->mclk) { > + if (!st->mclk) { > if (of_property_read_bool(np, "adi,int-clock-output-enable")) > clock_sel = AD7192_CLK_INT_CO; > } else {