From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Andrea Merello <andrea.merello@iit.it>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Jagath Jog J <jagathjog1996@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: add documentation for iio_chan_info_enum
Date: Sun, 16 Apr 2023 14:19:36 +0100 [thread overview]
Message-ID: <20230416141936.6e78b6c7@jic23-huawei> (raw)
In-Reply-To: <c221d0b5-a142-8154-08a1-5947d037d864@gmail.com>
On Wed, 12 Apr 2023 11:52:05 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 4/8/23 13:30, Jonathan Cameron wrote:
> > On Sat, 25 Feb 2023 15:55:25 +0200
> > Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> >
> >> + * @IIO_CHAN_INFO_INT_TIME: Integration time. Time during which the data is
> >> + * accumulated by the device.
> >
> > Unit? (seconds I think).
>
> Holy moly. Thanks for bringing this up now. I just checked this and the
> API doc indeed says clearly and loud the unit is in seconds. This means
> the BU27034 driver as well as the gain-time-scale helper does this
> wrong. I hope you can postpone sending them upstream until this gets
> fixed. I'll try to cook incremental patch on top of the iio/togreg - but
> I am not sure if I can do it today as I need to run after an hour...
> Sorry and thanks!
It's a fix so we have time. This one we'd take even if the driver
had made it to a release, but then we'd manage to annoy people.
Jonathan
>
> Yours,
> -- Matti
>
next prev parent reply other threads:[~2023-04-16 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 13:53 [PATCH v2 0/3] iio: Improce kernel docs Matti Vaittinen
2023-02-25 13:54 ` [PATCH v2 1/3] iio: Add some kerneldoc for channel types Matti Vaittinen
2023-04-08 10:18 ` Jonathan Cameron
2023-02-25 13:55 ` [PATCH v2 2/3] iio: add documentation for iio_chan_info_enum Matti Vaittinen
2023-04-08 10:30 ` Jonathan Cameron
2023-04-11 8:27 ` Vaittinen, Matti
2023-04-16 13:18 ` Jonathan Cameron
2023-04-12 8:52 ` Matti Vaittinen
2023-04-16 13:19 ` Jonathan Cameron [this message]
2023-02-25 13:56 ` [PATCH v2 3/3] doc: Make sysfs-bus-iio doc more exact Matti Vaittinen
2023-04-08 10:32 ` Jonathan Cameron
2023-04-09 9:47 ` Andy Shevchenko
2023-04-10 11:23 ` Jonathan Cameron
2023-02-26 17:22 ` [PATCH v2 0/3] iio: Improce kernel docs Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230416141936.6e78b6c7@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrea.merello@iit.it \
--cc=andy.shevchenko@gmail.com \
--cc=jagathjog1996@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox