Re: [PATCH v2 3/5] iio: accel: kionix-kx022a: Refactor driver and add chip_info structure

Mehdi Djait
2023-04-23T21:02:06Z

Hello Matti and Jonathan,

On Sat, Apr 22, 2023 at 06:32:46PM +0100, Jonathan Cameron wrote:
> On Fri, 21 Apr 2023 09:19:32 +0300
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
>
> > Hi Mehdi,
> >
> > Thanks for working on this driver :) Much appreciated!
> >
> > On 4/20/23 23:22, Mehdi Djait wrote:
> > > Refactor the kx022a driver implementation to make it more generic and
> > > extensible.
> > > Introduce an i2c_device_id table.
> > > Add the chip_info structure to the driver's private data to hold all
> > > the device specific infos.
> > >
> > > Signed-off-by: Mehdi Djait <mehdi.djait.k@gmail.com>
> > > ---
> > > v2:
> > > - mentioned the introduction of the i2c_device_id table in the commit
> >
> > Maybe adding the i2c_device_id table could be done in a separate patch
> > with a Fixes tag? That would help backporting (and I think changes like
> > this are worth it).
>
> Is it technically a fix? I thought it was but turned out my reasoning only
> applied to spi. Agreed it would be nice as a separate patch though.
> It's not directly related to the rest of what is happening here.

I will make it a separate patch in the v3

--
Kind Regard
Mehdi Djait