From: Jonathan Cameron <jic23@kernel.org>
To: Hermes Zhang <chenhuiz@axis.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>, Lars-Peter Clausen <lars@metafoo.de>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
Date: Sat, 22 Apr 2023 18:19:14 +0100 [thread overview]
Message-ID: <20230422181914.24810cc0@jic23-huawei> (raw)
In-Reply-To: <d92007ac-61e1-4328-f387-2b4e394977a8@axis.com>
On Sat, 22 Apr 2023 14:14:49 +0800
Hermes Zhang <chenhuiz@axis.com> wrote:
> 在 2023/4/21 16:23, Krzysztof Kozlowski 写道:
> > Didn't we start switching to compatible groups of devices? This looks
> > compatible with 20602.
>
> Hi Krzysztof,
>
> Sorry, I may not aware of this. Could you give some more info about the
> compatible groups? Yes, the icm20602 is quite similar as icm20600.
If it's compatible enough that a device tree that lists
compatible = "invensense,icm20600", "invensense,icm20602"
would work correctly with an old kernel by first checking for invensense,icm20600
then falling back to invense,icm20602 then it should be listed with that fallback.
See the existing block that covers the fallback form icm20608d to icm20608
- items:
- const: invensense,icm20608d
- const: invensense,icm20608
Note it is fine if the driver 'warns' that it's found a WHOAMI value it doesn't
know as long as it then goes on and works correctly. Thus there can't be
any incompatibilities between the two parts when we consider the functionality the
driver implements today. If we add features in future that aren't compatible, that's
fine because we will be matching against the more specific compatible you are
adding here.
Jonathan
>
> Thanks & Best Regards,
>
> Hermes
>
prev parent reply other threads:[~2023-04-22 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:16 [PATCH 0/2] Add support for the ICM 20600 IMU Hermes Zhang
2023-04-21 7:16 ` [PATCH 1/2] iio: imu: mpu6050: " Hermes Zhang
2023-04-22 17:21 ` Jonathan Cameron
2023-04-21 7:16 ` [PATCH 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050 Hermes Zhang
2023-04-21 8:23 ` Krzysztof Kozlowski
2023-04-22 6:14 ` Hermes Zhang
2023-04-22 17:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230422181914.24810cc0@jic23-huawei \
--to=jic23@kernel.org \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox