public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: lars@metafoo.de, alexandre.torgue@foss.st.com,
	nuno.sa@analog.com, linux-iio@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2] iio: adc: stm32-adc: add debug info if dt uses legacy channel config
Date: Sun, 23 Apr 2023 13:59:33 +0100	[thread overview]
Message-ID: <20230423135933.2dfb540b@jic23-huawei> (raw)
In-Reply-To: <20230421083858.2613289-1-sean@geanix.com>

On Fri, 21 Apr 2023 10:38:58 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> Since nearly all stm32 dt's are using the legacy adc channel config,
> we should warn users about using it.
> 
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
This is far enough (I think) from the code touched in the fixes
(I'm waiting for review from Olivier for those) that I can merge
it through a different branch.   So taken this one for the togreg branch of
iio.git - initially pushed out as testing for 0-day to take a poke at it.

Thanks,

Jonathan

> ---
> Changes since v1:
>  - Changed dev_warn -> dev_dbg
> 
>  drivers/iio/adc/stm32-adc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index 1aadb2ad2cab..e179b6611e4d 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1993,6 +1993,8 @@ static int stm32_adc_get_legacy_chan_count(struct iio_dev *indio_dev, struct stm
>  	const struct stm32_adc_info *adc_info = adc->cfg->adc_info;
>  	int num_channels = 0, ret;
>  
> +	dev_dbg(&indio_dev->dev, "using legacy channel config\n");
> +
>  	ret = device_property_count_u32(dev, "st,adc-channels");
>  	if (ret > adc_info->max_channels) {
>  		dev_err(&indio_dev->dev, "Bad st,adc-channels?\n");


      reply	other threads:[~2023-04-23 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  8:38 [PATCH v2] iio: adc: stm32-adc: add debug info if dt uses legacy channel config Sean Nyekjaer
2023-04-23 12:59 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230423135933.2dfb540b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=nuno.sa@analog.com \
    --cc=sean@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox