From: "Patrik Dahlström" <risca@dalakolonin.se>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: adc: palmas: fix off by one bugs
Date: Sat, 29 Apr 2023 22:25:38 +0200 [thread overview]
Message-ID: <20230429202538.GC1404696@dalakolonin.se> (raw)
In-Reply-To: <20230423141124.3d4dc91d@jic23-huawei>
On Sun, Apr 23, 2023 at 02:11:24PM +0100, Jonathan Cameron wrote:
> On Fri, 21 Apr 2023 13:41:56 +0300
> Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> > Valid values for "adc_chan" are zero to (PALMAS_ADC_CH_MAX - 1).
> > Smatch detects some buffer overflows caused by this:
> > drivers/iio/adc/palmas_gpadc.c:721 palmas_gpadc_read_event_value() error: buffer overflow 'adc->thresholds' 16 <= 16
> > drivers/iio/adc/palmas_gpadc.c:758 palmas_gpadc_write_event_value() error: buffer overflow 'adc->thresholds' 16 <= 16
> >
> > The effect of this bug in other functions is more complicated but
> > obviously we should fix all of them.
> >
> > Fixes: a99544c6c883 ("iio: adc: palmas: add support for iio threshold events")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Looks good to me. Slight shuffle at the moment will delay me applying this.
>
> I'll wait for Linus to pick up Greg's pull request then rebase my fixes branch
> on top of that. Otherwise I make a mess of linux-next ordering and things might
> blow up.
>
> In meantime, Patrik, please take a look.
Sorry for the long delay.
The changes look good to me. I've checked all other uses of adc_chan in the
code and they all seem to be guarded by the checks below.
Best regards
Patrik
>
> Jonathan
>
> > ---
> > ---
> > drivers/iio/adc/palmas_gpadc.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> > index c1c439215aeb..7dfc9c927a23 100644
> > --- a/drivers/iio/adc/palmas_gpadc.c
> > +++ b/drivers/iio/adc/palmas_gpadc.c
> > @@ -547,7 +547,7 @@ static int palmas_gpadc_read_raw(struct iio_dev *indio_dev,
> > int adc_chan = chan->channel;
> > int ret = 0;
> >
> > - if (adc_chan > PALMAS_ADC_CH_MAX)
> > + if (adc_chan >= PALMAS_ADC_CH_MAX)
> > return -EINVAL;
> >
> > mutex_lock(&adc->lock);
> > @@ -595,7 +595,7 @@ static int palmas_gpadc_read_event_config(struct iio_dev *indio_dev,
> > int adc_chan = chan->channel;
> > int ret = 0;
> >
> > - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > return -EINVAL;
> >
> > mutex_lock(&adc->lock);
> > @@ -684,7 +684,7 @@ static int palmas_gpadc_write_event_config(struct iio_dev *indio_dev,
> > int adc_chan = chan->channel;
> > int ret;
> >
> > - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > return -EINVAL;
> >
> > mutex_lock(&adc->lock);
> > @@ -710,7 +710,7 @@ static int palmas_gpadc_read_event_value(struct iio_dev *indio_dev,
> > int adc_chan = chan->channel;
> > int ret;
> >
> > - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > return -EINVAL;
> >
> > mutex_lock(&adc->lock);
> > @@ -744,7 +744,7 @@ static int palmas_gpadc_write_event_value(struct iio_dev *indio_dev,
> > int old;
> > int ret;
> >
> > - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH)
> > return -EINVAL;
> >
> > mutex_lock(&adc->lock);
>
next prev parent reply other threads:[~2023-04-29 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 10:41 [PATCH] iio: adc: palmas: fix off by one bugs Dan Carpenter
2023-04-23 13:11 ` Jonathan Cameron
2023-04-29 20:25 ` Patrik Dahlström [this message]
2023-05-01 15:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230429202538.GC1404696@dalakolonin.se \
--to=risca@dalakolonin.se \
--cc=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox