From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: fix doc for iio_gts_find_sel_by_int_time
Date: Mon, 1 May 2023 16:41:57 +0100 [thread overview]
Message-ID: <20230501164157.43ed033e@jic23-huawei> (raw)
In-Reply-To: <ZEIjI4YUzqPZk/9X@fedora>
On Fri, 21 Apr 2023 08:46:11 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> The kerneldoc for iio_gts_find_sel_by_int_time() has an error.
> Documentation states that function is searching a selector for a HW-gain
> while it is searching a selector for an integration time.
>
> Fix the documentation by saying the function is looking for a selector
> for an integration time.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Given this is a very recent introduction and I don't like incorrect docs
sneaking in, I've applied this to the fixes-togreg branch of iio.git
(which just got rebased on char-misc-linus which now includes this code).
Thanks,
Jonathan
> ---
> include/linux/iio/iio-gts-helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio-gts-helper.h b/include/linux/iio/iio-gts-helper.h
> index dd64e544a3da..9cb6c80dea71 100644
> --- a/include/linux/iio/iio-gts-helper.h
> +++ b/include/linux/iio/iio-gts-helper.h
> @@ -135,7 +135,7 @@ static inline int iio_gts_find_int_time_by_sel(struct iio_gts *gts, int sel)
> /**
> * iio_gts_find_sel_by_int_time - find selector matching integration time
> * @gts: Gain time scale descriptor
> - * @gain: HW-gain for which matching selector is searched for
> + * @time: Integration time for which matching selector is searched for
> *
> * Return: a selector matching given integration time or -EINVAL if
> * selector was not found.
>
> base-commit: 52cc189b4fc6af6accc45fe7b7053d76d8724059
prev parent reply other threads:[~2023-05-01 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 5:46 [PATCH] iio: fix doc for iio_gts_find_sel_by_int_time Matti Vaittinen
2023-05-01 15:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501164157.43ed033e@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox